Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8E9242F2E for ; Mon, 11 Jul 2022 14:35:43 +0000 (UTC) Date: Mon, 11 Jul 2022 16:35:39 +0200 From: Pablo Neira Ayuso To: Bill Wendling Cc: isanbard@gmail.com, Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ross Philipson , Daniel Kiper , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev Subject: Re: [PATCH 12/12] netfilter: conntrack: use correct format characters Message-ID: References: <20220609221702.347522-1-morbo@google.com> <20220609221702.347522-13-morbo@google.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220609221702.347522-13-morbo@google.com> On Thu, Jun 09, 2022 at 10:16:31PM +0000, Bill Wendling wrote: > From: Bill Wendling > > When compiling with -Wformat, clang emits the following warnings: > > net/netfilter/nf_conntrack_helper.c:168:18: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] > request_module(mod_name); > ^~~~~~~~ > > Use a string literal for the format string. Applied this patch to nf-next, thanks