Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36535C433EF for ; Mon, 18 Jul 2022 19:13:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235483AbiGRTNh (ORCPT ); Mon, 18 Jul 2022 15:13:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235502AbiGRTNf (ORCPT ); Mon, 18 Jul 2022 15:13:35 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B27EE2F675; Mon, 18 Jul 2022 12:13:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hzGG9ZYZ55lKs6v2KVZ6O+kfdHURFCGB0YnSpUgcYZ8=; b=D2iVCJeyJxa+EiXw+UZLdtVWwW CNBQeh7P4yswurTkhGjLWskLvcCCFr16C6HwZhuWVbHzUShXL6TxoOuu9b+sCJUhqPAnJUoOD3FnX CYva/z5J+KHyPgYdh5J2GvbLhS/AHkpZbFgICeW/pxxup0+gGL0s0kR6FLEBoEAAEPcYPS9zvkt3P oh7LuL7/up9HHYoeVwZEpGDjgQvMMiy36PjMQvbXHbP7gCxuJxa1d+h+BhbaUTu9h/id5u6nfVNnY 2SsbVHEx7ZT5XL1cdfH8f0G9pCMqIBoBoEvGyUuIiK+h8/AhlE1Le3GUzJ3r1y+EzidNMjFifvwHx rjGx0RHw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:33432) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oDWBF-00022G-A5; Mon, 18 Jul 2022 20:13:21 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oDWBD-0002D2-TZ; Mon, 18 Jul 2022 20:13:19 +0100 Date: Mon, 18 Jul 2022 20:13:19 +0100 From: "Russell King (Oracle)" To: Andy Shevchenko Cc: Andrew Lunn , Heiner Kallweit , Alexandre Belloni , Alvin __ipraga , Claudiu Manoil , Daniel Scally , "David S. Miller" , DENG Qingfang , Eric Dumazet , Florian Fainelli , George McCollister , Greg Kroah-Hartman , Hauke Mehrtens , Heikki Krogerus , Jakub Kicinski , Kurt Kanzenbach , Landen Chao , Linus Walleij , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Matthias Brugger , netdev@vger.kernel.org, Paolo Abeni , "Rafael J. Wysocki" , Sakari Ailus , Sean Wang , UNGLinuxDriver@microchip.com, Vivien Didelot , Vladimir Oltean , Woojung Huh , Marek =?iso-8859-1?Q?Beh=FAn?= Subject: Re: [PATCH net-next 5/6] net: dsa: use swnode fixed-link if using default params Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Jul 18, 2022 at 09:59:25PM +0300, Andy Shevchenko wrote: > On Fri, Jul 15, 2022 at 10:36:29PM +0100, Russell King (Oracle) wrote: > > On Fri, Jul 15, 2022 at 11:11:18PM +0300, Andy Shevchenko wrote: > > > On Fri, Jul 15, 2022 at 05:01:48PM +0100, Russell King (Oracle) wrote: > > ... > > > > > Co-developed by Vladimir Oltean and myself. > > > > > > Why not to use > > > > > > Co-developed-by: Vladimir Oltean > > > > Ah, that's an official thing. Thanks. > > Yep, it's even documented in Submitting Patches. > > ... > > > > > + phy_node = of_parse_phandle(dn, "phy-handle", 0); > > > > > > fwnode in the name, why not to use fwnode APIs? > > > > > > fwnode_find_reference(); > > > > Marcin has a series converting DSA to use fwnode things - currently DSA > > does not support ACPI, so converting it to fwnode doesn't make that much > > sese until the proper ACPI patches get merged, which have now been > > rebased on this series by Marcin in the expectation that these patches > > would be merged... so I don't want to tred on Marcin's feet on that. > > But it's normal development process... > > Anyway, it seems to me that you are using fwnode out of that (with the > exception of one call). To me it looks that you add a work to him, rather > than making his life easier, since you know ahead that this is going to be > converted. No, I didn't know ahead of time until Marcin piped up about it, and then we discussed how to resolve the conflict between the two patch sets. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!