Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B27E2C433EF for ; Fri, 22 Jul 2022 13:20:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234542AbiGVNUn (ORCPT ); Fri, 22 Jul 2022 09:20:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235110AbiGVNUj (ORCPT ); Fri, 22 Jul 2022 09:20:39 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65DAE25C7B; Fri, 22 Jul 2022 06:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=uzQ8w7rKAbkoZSRPJucJAgUKh5DCe2hdLAcL4aCnnMM=; b=6M9TuGazI4VSoJjq0Q/Cvs2mB1 nIo1v/t8G4J4dFKa6IX82Q4VNZsaTLN5Zg0caUFGesKBHe0zkpVo+KMDaQEC5mi2vUQrXaZH2euZe 7/OEkNcwx6P7d7/6i9usYKNx5ub6s1TnBdg6nweAQ3IFbkRdxh2FzH0Iwk/EMoWeIQak=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oEsZY-00B8mU-Ce; Fri, 22 Jul 2022 15:20:04 +0200 Date: Fri, 22 Jul 2022 15:20:04 +0200 From: Andrew Lunn To: "Russell King (Oracle)" Cc: Vladimir Oltean , Marek =?iso-8859-1?Q?Beh=FAn?= , Heiner Kallweit , Alexandre Belloni , Alvin __ipraga , Andy Shevchenko , Claudiu Manoil , Daniel Scally , "David S. Miller" , DENG Qingfang , Eric Dumazet , Florian Fainelli , George McCollister , Greg Kroah-Hartman , Hauke Mehrtens , Heikki Krogerus , Jakub Kicinski , Kurt Kanzenbach , Landen Chao , Linus Walleij , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Matthias Brugger , netdev@vger.kernel.org, Paolo Abeni , "Rafael J. Wysocki" , Sakari Ailus , Sean Wang , UNGLinuxDriver@microchip.com, Vivien Didelot , Woojung Huh Subject: Re: [PATCH net-next 3/6] net: dsa: add support for retrieving the interface mode Message-ID: References: <20220721151533.3zomvnfogshk5ze3@skbuf> <20220721192145.1f327b2a@dellmb> <20220721192145.1f327b2a@dellmb> <20220721182216.z4vdaj4zfb6w3emo@skbuf> <20220721213645.57ne2jf7f6try4ec@skbuf> <20220722105238.qhfq5myqa4ixkvy4@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org > > The way I understand what you're saying is that there is no guarantee > > that the DSA master and CPU port will agree whether to use in-band > > autoneg or not here (and implicitly, there is no guarantee that this > > link will work): > > > > ð0 { > > phy-mode = "2500base-x"; > > managed = "in-band-status"; > > }; > > > > &switch_cpu_port { > > ethernet = <ð0>; > > phy-mode = "25000base-x"; > > I'll assume that 25000 is a typo. > > > managed = "in-band-status"; > > }; > > Today, there is no guarantee - because it depends on how people have > chosen to implement 2500base-X, and whether the hardware requires the > use of in-band AN or prohibits it. In practice, a Marvell MAC and a Marvell switch are likely to work, since Marvell produce and tested both ends. I would expect this to be true for any vendor. It is only going to be a problem when you have devices from different vendors. And they have different interpretations of what 2500Base-X is. So far, mixed vendor systems tend to be 1) Freescale FEC and Marvell switches, and the FEC it still only 1G RGMII 2) The smaller simpler devices which are 1G and do not yet use a SERDES. So this might be a future problem we will have, as more devices start supporting 2.5G and 5G, but hopefully those future devices follow the standard. Andrew