Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE358C19F2D for ; Sat, 6 Aug 2022 15:23:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232578AbiHFPXQ (ORCPT ); Sat, 6 Aug 2022 11:23:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232573AbiHFPXJ (ORCPT ); Sat, 6 Aug 2022 11:23:09 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 250D712AA4; Sat, 6 Aug 2022 08:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=LsVNe76Un0AnuesL7EI/gnhf6nk5hE/4yiJkLEtbPAU=; b=OTYJtH4/uMQh0hpBBIEx/vbAwJ CmhYJ2CzuLT69dmAy1HeVbF/h3cRy+9GCtEKYSdFbmnWhlTct8pCxWZilOSEImkd40BzZAAH2ZvJD OtSdn7ET/a1JGeGy/sdtylNG+lK0BQVwpNY00aovvPAg2JM9Ad6r2D6KOlMxxsw7H99w=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oKLdo-00CZsW-7y; Sat, 06 Aug 2022 17:23:04 +0200 Date: Sat, 6 Aug 2022 17:23:04 +0200 From: Andrew Lunn To: Jose Alonso Cc: "David S. Miller" , Greg Kroah-Hartman , netdev , stable , Ronald Wahl Subject: Re: [PATCH v2 net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP Message-ID: References: <9a6829ee42e4e88639d35428c378f9da7802245b.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9a6829ee42e4e88639d35428c378f9da7802245b.camel@gmail.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Aug 05, 2022 at 05:27:33PM -0300, Jose Alonso wrote: > To: David S. Miller , Greg Kroah-Hartman > Cc: netdev , stable , Ronald Wahl > > [PATCH net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP > The usage of FLAG_SEND_ZLP causes problems to other firmware/hardware > versions that have no issues. > > The FLAG_SEND_ZLP is not safe to use in this context. > See: > https://patchwork.ozlabs.org/project/netdev/patch/1270599787.8900.8.camel@Linuxdev4-laptop/#118378 > > Reported-by: Ronald Wahl > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216327 > Link: https://bugs.archlinux.org/task/75491 > > Fixes: 36a15e1cb134 ("net: usb: ax88179_178a needs FLAG_SEND_ZLP") > Signed-off-by: Jose Alonso > > -- Please take a read of: https://kernel.org/doc/html/latest/process/submitting-patches.html It should explain all the things you are getting wrong. It is also worth looking at a few patches on the mailing list which do get accepted. Look at there format and copy them. Andrew