Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7544EC19F2C for ; Wed, 3 Aug 2022 18:21:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231998AbiHCSVV (ORCPT ); Wed, 3 Aug 2022 14:21:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237264AbiHCSVU (ORCPT ); Wed, 3 Aug 2022 14:21:20 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE34A6402 for ; Wed, 3 Aug 2022 11:21:19 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id s5-20020a17090a13c500b001f4da9ffe5fso2827183pjf.5 for ; Wed, 03 Aug 2022 11:21:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=nsqh0CIbwvJ/pgXSEB6oG4Xy1/woHrUtn/IceLa3N0o=; b=Mz7gnu/VZCsDdtuvgzoWWrZTyBOivrPLG1HNJ+EOLit/5tJ/Xiahx1DIxiLjo95pbf RexuAaGX8IeAIu9IinuPXQdSjBPX2mDsVVYCCThWPPEEPOiwxkTnRNC0l7Yk6GMz11jD NWzbZn4FYbhn5O4VetrsjMKxxVhWt8sXSictshJmlEKoCWRm7sVWeSriiEK7Y4rlkn+5 /+B79Z4ExSGtJBY+K0J6QeqD+B6MmslHI4xNwWaawrssbEY+JiPLvTzwuOFgt13/Wqh8 yEBx94gSJC/S1W0syyNwJMK1HPX9xphMR3G7vdr4r7kCFAP17Mq0hZGh2SW3KDjMPDrs tUIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=nsqh0CIbwvJ/pgXSEB6oG4Xy1/woHrUtn/IceLa3N0o=; b=h6qNgb7CHfDSi54ksaiK+VU9Szu1/6GT/pOOoDbMTkZFLvP58riOTBsDQHqlRR+9qs tEIcfrBfurk5nTHIrTdqwM8vsyjXinnd3sSZhdYJdjIeOPmyE7J5Zj7GqYYvd/juLAKL j8sJV4y2I7TX4jo0S1907MXnr6a05nwJjHMHJenYjzb0eoU+2Naz1xCWqYx/xQ7LzDVK bEtB6kTJBRc0PblIVWkhneDuYeE8MT3ANDJj7FuNI1BykprEYwpj3IIBJ5sXARaLEdxS wI3guS5HImv/Y+qoHYZWkVv7cxsF+ouCsiWzh7oHpQBJdgwyhXDegUJNaVVvfQvAsvOT UAJQ== X-Gm-Message-State: ACgBeo1uaR7TNnEvCgxsHGUjeid1amV34ir8qzHyueaKc9tJPDDh9H3x 6f37bEKzQmY+ueO7gzqkiStMTg== X-Google-Smtp-Source: AA6agR4YSibnTcRYrFz2ZoDNodfpJuyX4JLT+iJz7Yvex1VpFcHWlYEO9XxUz12BN03Te3VybjNJjw== X-Received: by 2002:a17:902:f688:b0:16f:28:ea27 with SMTP id l8-20020a170902f68800b0016f0028ea27mr10761229plg.151.1659550879177; Wed, 03 Aug 2022 11:21:19 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id l16-20020a170903121000b0016bfbd99f64sm2299900plh.118.2022.08.03.11.21.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Aug 2022 11:21:18 -0700 (PDT) Date: Wed, 3 Aug 2022 18:21:14 +0000 From: Sean Christopherson To: Michal Luczaj Cc: kvm@vger.kernel.org, pbonzini@redhat.com, shuah@kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [kvm-unit-tests PATCH 2/4] x86: emulator.c cleanup: Use ASM_TRY for the UD_VECTOR cases Message-ID: References: <20220803172508.1215-1-mhal@rbox.co> <20220803172508.1215-2-mhal@rbox.co> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220803172508.1215-2-mhal@rbox.co> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Aug 03, 2022, Michal Luczaj wrote: > For #UD handling use ASM_TRY() instead of handle_exception(). > > Suggested-by: Sean Christopherson > Signed-off-by: Michal Luczaj > --- > I've noticed test_illegal_movbe() does not execute with KVM_FEP. > Just making sure: is it intentional? It's intentional. FEP isn't needed because KVM emulates MOVBE on #UD when it's not supported by the host, e.g. to allow migrating to an older host. GP(EmulateOnUD | ModRM, &three_byte_0f_38_f0), GP(EmulateOnUD | ModRM, &three_byte_0f_38_f1),