Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C629ECAAD4 for ; Wed, 31 Aug 2022 10:46:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230020AbiHaKqt (ORCPT ); Wed, 31 Aug 2022 06:46:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229607AbiHaKqt (ORCPT ); Wed, 31 Aug 2022 06:46:49 -0400 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71D3EC2E85 for ; Wed, 31 Aug 2022 03:46:47 -0700 (PDT) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1oTLF1-0000S6-8n; Wed, 31 Aug 2022 12:46:39 +0200 Date: Wed, 31 Aug 2022 12:46:39 +0200 From: Phil Sutter To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH nft] src: allow burst 0 for byte ratelimit and use it as default Message-ID: Mail-Followup-To: Phil Sutter , Pablo Neira Ayuso , netfilter-devel@vger.kernel.org References: <20220830153746.94996-1-pablo@netfilter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220830153746.94996-1-pablo@netfilter.org> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Aug 30, 2022 at 05:37:46PM +0200, Pablo Neira Ayuso wrote: > Packet-based limit burst is set to 5, as in iptables. However, > byte-based limit burst adds to the rate to calculate the bucket size, > and this is also sets this to 5 (... bytes in this case). Update it to > use zero byte burst by default instead. > > This patch also updates manpage to describe how the burst value > influences the kernel module's token bucket in each of the two modes. > This documentation update is based on original text by Phil Sutter. > > Adjust tests/py to silence warnings due to mismatching byte burst. > > Fixes: 285baccfea46 ("src: disallow burst 0 in ratelimits") > Signed-off-by: Pablo Neira Ayuso Acked-by: Phil Sutter Thanks for taking over the man page adjustment!