Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 063FDC00140 for ; Sun, 21 Aug 2022 16:45:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231209AbiHUQpg (ORCPT ); Sun, 21 Aug 2022 12:45:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229690AbiHUQpS (ORCPT ); Sun, 21 Aug 2022 12:45:18 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67CE81AD92 for ; Sun, 21 Aug 2022 09:45:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=yFMNSnmj7C8UmIwLtlsYTL6TUIypc0t7yTNxPd1HbSY=; b=K9uGQNnS2q2inPV+R26e08ZRlv etfR7CtrwlbJSxc3kds0gHj+Rbxi8xfT2yJN3KCsCPqCjRpQUHJ94AKiZH1JpLFuqKt9WeZcToKSJ Fjg/yTaRcJ1E0IqU7H46iao++Ewg8xn9+EG7/No4iufFEUaKNctrkTPZdncslBSksFqw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oPo4Y-00E9Kd-5h; Sun, 21 Aug 2022 18:45:14 +0200 Date: Sun, 21 Aug 2022 18:45:14 +0200 From: Andrew Lunn To: Sergei Antonov Cc: netdev@vger.kernel.org, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org Subject: Re: [PATCH] net: ftmac100: set max_mtu to allow DSA overhead setting Message-ID: References: <20220821160844.474277-1-saproj@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220821160844.474277-1-saproj@gmail.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Aug 21, 2022 at 07:08:44PM +0300, Sergei Antonov wrote: > In case ftmac100 is used with a DSA switch, Linux wants to set MTU > to 1504 to accommodate for DSA overhead. With the default max_mtu > it leads to the error message: > ftmac100 92000000.mac eth0: error -22 setting MTU to 1504 to include DSA overhead > > ftmac100 supports packet length 1518 (MAX_PKT_SIZE constant), so it is > safe to report it in max_mtu. > > Signed-off-by: Sergei Antonov Reviewed-by: Andrew Lunn Andrew