Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1oRJ0a-0006lB-3s for mharc-grub-devel@gnu.org; Thu, 25 Aug 2022 15:59:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRJ0W-0006k2-GB for grub-devel@gnu.org; Thu, 25 Aug 2022 15:59:16 -0400 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]:34714) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRJ0S-0006lY-Ne for grub-devel@gnu.org; Thu, 25 Aug 2022 15:59:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oGXSH9pQ7/gXzBWRD7OGDaYXnd2azXtNQrxqCMYde1g=; b=NWFmBvslpbPMOVXg4OjIDmdAND T8x/fB6yXVEKgsth/PqXoRIIOEMUZm9/Py1cvngaby3WLEXNCTTKh2MRjumNvrW5u9F2Kat9D7GrU fmjhN19B/Vez1JjGqT9y+UQb2I5dnhiyoqQUUbswjAoA2lL8X2F9Lc/Pgedeg8Uj0IjS5Dxfkjecr HXZe43mqj+wO4I6j1jcXqaGsXzkHxi9IkoHY/IdE9wiimoY+27glx1uOhIkgtJEj+i4AQ8ECyC2kC cgkRU7sW8k5lZ2gp+oWmmaQGPKOWD8YXOcs0I/3d4vKB9wtyMpv9/DyZUd/rjX/gI36RlRy0tWFiw SMdCzWCw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRJ0I-0065yo-Pz; Thu, 25 Aug 2022 19:59:03 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id D2F129800E6; Thu, 25 Aug 2022 21:59:01 +0200 (CEST) Date: Thu, 25 Aug 2022 21:59:01 +0200 From: Peter Zijlstra To: Glenn Washburn Cc: The development of GNU GRUB , Daniel Kiper Subject: Re: [PATCH] term/serial: Add support for PCI serial devices Message-ID: References: <20220824151355.6312d89d@crass-HP-ZBook-15-G2> <20220824183627.62abec4e@crass-HP-ZBook-15-G2> <20220825142320.47e09095@crass-HP-ZBook-15-G2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220825142320.47e09095@crass-HP-ZBook-15-G2> Received-SPF: none client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; envelope-from=peterz@infradead.org; helo=desiato.infradead.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Aug 2022 19:59:16 -0000 On Thu, Aug 25, 2022 at 02:23:34PM -0500, Glenn Washburn wrote: > > diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def > > index 5212dfab1369..c0683da2353b 100644 > > --- a/grub-core/Makefile.core.def > > +++ b/grub-core/Makefile.core.def > > @@ -224,12 +224,14 @@ kernel = { > > > > i386_efi = kern/i386/efi/init.c; > > i386_efi = bus/pci.c; > > + i386_efi_cppflags = '-DGRUB_HAS_PCI'; > > I imagine this should be enabled for all i386 and x86_64 targets, not > just the few that you have here. For instance, what about i386-pc, > which is the 32-bit BIOS target? So what I did was put that _cppflags thing right next to all the 'bus/pci.c' instances I found, with exception of the pci module. Where do i386-pc and friends get it from? IOW, what obvious place did I miss?