Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23C82C07E9D for ; Mon, 26 Sep 2022 14:52:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GgQCfShhg6c4Yw2GAHv1kM3Vj/4PRsYwZj4e6bUmfM4=; b=j3h4PEXG2YFVMI/JU13yLhiuKu uJYHoJHz6r+JaDexBf+XjgmHNUPxBjrSi0l8WIH94mE6fYEX9CWX1RTaC2lrMZQrIRuaJKj1ZBXeh XPkbfij8hP7lcEm0brZDbQsmTVrm6154rcN4whIt6wKDsazEvFyyNb31BsxaDkb+9z47rNOJHidEo LRRoedDm2IZcnom5BzhYn1w0b8zCCN9hCZeD7D7rR6MQgiGDvB1F0gviRa2pu31XVciNi63o78vpt YC5vk181e+35xRSyYCbyxvdu6kBYfgGOEfrtDIHigJmouL3DGIM4NwXRcyUNCTE0zQR1yOD5OwPXe 8Xn7QTzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocpTY-005Vov-EF; Mon, 26 Sep 2022 14:52:52 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocpTS-005Vm6-5p; Mon, 26 Sep 2022 14:52:46 +0000 Date: Mon, 26 Sep 2022 07:52:46 -0700 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, Stefan Roesch Subject: Re: [PATCH 4/5] nvme: split out metadata vs non metadata end_io uring_cmd completions Message-ID: References: <20220922182805.96173-1-axboe@kernel.dk> <20220922182805.96173-5-axboe@kernel.dk> <69598e37-fb91-5b92-bb80-b68457a7b6f8@kernel.dk> <25b9899f-0c60-39f2-179b-789b914e0f0a@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <25b9899f-0c60-39f2-179b-789b914e0f0a@kernel.dk> X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Sep 26, 2022 at 08:50:41AM -0600, Jens Axboe wrote: > Or just the union named so it's clear it's a union? That'd make it > > pdu->u.meta > > and so forth. I think that might be cleaner. Ok, that's at least a bit of a warning sign.