Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52881C04A95 for ; Wed, 28 Sep 2022 19:37:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 633AB6B0072; Wed, 28 Sep 2022 15:37:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BB286B0073; Wed, 28 Sep 2022 15:37:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40DD96B0074; Wed, 28 Sep 2022 15:37:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2C3026B0072 for ; Wed, 28 Sep 2022 15:37:05 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D239BAADDC for ; Wed, 28 Sep 2022 19:37:04 +0000 (UTC) X-FDA: 79962502368.16.D646F1F Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by imf18.hostedemail.com (Postfix) with ESMTP id 742C61C0015 for ; Wed, 28 Sep 2022 19:37:04 +0000 (UTC) Received: by mail-io1-f52.google.com with SMTP id z191so10974260iof.10 for ; Wed, 28 Sep 2022 12:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=w+64nBC9flQuRlvFf/LyNi8vAIoeFZlmjiGW7/Cl9GA=; b=W1oLTSde5Qwb++pbSaUe4lWBe586C2QHURCizljXgg5WUYP5/EWw76ThSDAmN8HdLN 1bn2X8u17DOL6ZgiSEAOjjzoUl0ujoEeqIqAEMA3x4+hZclF9cxqSuvfrOm66gTJvflh A92GVUKk1qjCxsntZgVqbe2oBEeMo3tqY1nO/yRnkJRglartg9jnsTgHrlNRscXIikWy n2UW5230gSIvPlWMoDgw2rolIttjNi28MVW1qEFn6Ed0Q+1wPFYGc245TNoRKM4VXfHL rQZOyeQfp22g8RGWrVUD5FqoZ4l+WHWCEaG5YRAVet6EKIz5JM1019yWewHiNCSt3tYp 9DKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=w+64nBC9flQuRlvFf/LyNi8vAIoeFZlmjiGW7/Cl9GA=; b=4vlJZNXxLvCYyoZoZHlKRPSU6EqKvPw4oG8umvz4ulNIA6kgkkQVdnbN3vBHXWmXsh 0zCI+dzYOqZeiNd6tT5/DwQwIE/dR5eRHGrhinKOeggoIBWwMKTLbvjY31i/1HFQ4Gpj nJa3VxbntT6XC+TdMR/aLyjo3onvBpNPj8WIMdkdkmeVwy7mS5t85Dqj4GnWlU7dOAD3 iw0wbXV3p5gVQjJpD17cJ1yvrEhYSs+wnUiJxLZQ4dmlIgOd8ok7B8u9Y8SvZCjA/5uo Poq5XUdvAkBNAPkEUKG4OVW+kUL+ea5S9FSLLIxmU0ayK+/Zz6lEjo0zX/sShBcD/bw/ Melw== X-Gm-Message-State: ACrzQf3L0MgDFx1bQNuEUwNJGv8wNR6pg+oqXs/kDlo7tEojvVsTW2zz kygiL+d1ITFOFmH2XvmVhiH1NA== X-Google-Smtp-Source: AMsMyM4pvj/63KDkjqfOHv+ZDuiHOFQWJwmRPDGjn/J9jBlb8WWfq0hCxV1lxPeDvR8N5J4PM3KGgA== X-Received: by 2002:a02:c6d4:0:b0:35a:4ea3:4890 with SMTP id r20-20020a02c6d4000000b0035a4ea34890mr1234303jan.215.1664393823556; Wed, 28 Sep 2022 12:37:03 -0700 (PDT) Received: from google.com ([2620:15c:183:200:e132:6c29:fb2a:a1b]) by smtp.gmail.com with ESMTPSA id z25-20020a6be019000000b006814fd71117sm2283016iog.12.2022.09.28.12.37.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 12:37:03 -0700 (PDT) Date: Wed, 28 Sep 2022 13:36:58 -0600 From: Yu Zhao To: Andrew Morton Cc: Andi Kleen , Aneesh Kumar , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Peter Zijlstra , Tejun Heo , Vlastimil Babka , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, page-reclaim@google.com, Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , Holger =?iso-8859-1?Q?Hoffst=E4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain Subject: Re: [PATCH mm-unstable v15 08/14] mm: multi-gen LRU: support page table walks Message-ID: References: <20220918080010.2920238-1-yuzhao@google.com> <20220918080010.2920238-9-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220918080010.2920238-9-yuzhao@google.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664393824; a=rsa-sha256; cv=none; b=iGU6ZumxBE7eScUhwy8p3U5g1/ETF9rHA6yClk5LZcTmdMv64BSYfm+n5RVkF6IqXrCuyH KKhjUtb8xX7Tcmci3ivWhNBcA6AcWRmyh5sz5gNGFKZIKVYTIegyxHw2xJulIdIJ9PDB/Z IcIIS7Y6a+iT3EYFK2WVrLWYlx1gyuE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=W1oLTSde; spf=pass (imf18.hostedemail.com: domain of yuzhao@google.com designates 209.85.166.52 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664393824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w+64nBC9flQuRlvFf/LyNi8vAIoeFZlmjiGW7/Cl9GA=; b=qiAc61jLy2uLQNJ9f9H+MgKYDefJo66p5Rydol2hN5NKtuCQoRloLa8VPmgDZA4M+seoVp B0GX+8jmD3SeGOLSfgK+F/t6cTqWlDiFa/gwn8IyhQpAgpZoM8tluK+XIYsaEqr591Ca9c AnG1HOdy1WOuth3+thucwHEL+eegTiM= X-Stat-Signature: pefim5kyns55fktki586frp6srgi4ocj X-Rspamd-Queue-Id: 742C61C0015 X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=W1oLTSde; spf=pass (imf18.hostedemail.com: domain of yuzhao@google.com designates 209.85.166.52 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam01 X-HE-Tag: 1664393824-858190 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Andrew, Can you please take another fixlet? Thanks. Don't sync disk for each aging cycle. wakeup_flusher_threads() was added under the assumption that if a system runs out of clean cold pages, it might want to write back dirty pages more aggressively so that they can become clean and be dropped. However, doing so can breach the rate limit a system wants to impose on writeback, resulting in early SSD wearout. Reported-by: Axel Rasmussen Signed-off-by: Yu Zhao --- mm/vmscan.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 5b565470286b..0317d4cf4884 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -4413,8 +4413,6 @@ static bool try_to_inc_max_seq(struct lruvec *lruvec, unsigned long max_seq, if (wq_has_sleeper(&lruvec->mm_state.wait)) wake_up_all(&lruvec->mm_state.wait); - wakeup_flusher_threads(WB_REASON_VMSCAN); - return true; } -- 2.37.3.998.g577e59143f-goog