Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1oeDqh-0008Si-BV for mharc-grub-devel@gnu.org; Fri, 30 Sep 2022 07:06:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39676) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oeDqf-0008Rs-ER for grub-devel@gnu.org; Fri, 30 Sep 2022 07:06:29 -0400 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]:42659) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oeDqd-0005VF-UU for grub-devel@gnu.org; Fri, 30 Sep 2022 07:06:29 -0400 Received: by mail-pg1-x534.google.com with SMTP id e129so3867060pgc.9 for ; Fri, 30 Sep 2022 04:06:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=IkzHvE2MjcT5CaQKY7CS4Qpfvx8aXUR2/xO88KdGfvM=; b=ARkxnBt+4w9awn+EV7nwtvaOgAWjFgjGwLWIiAhmaNfwbXYxHawNYm0FWbb7jg3hqU 4rGRmbazn+jwTb7erMPBZO/gBrfSJN70CNDHMEAwyDfuxHAFVGkzm9MvpMrTkQvGnxEz yvFGYBZhHyn/bBzNyIhmSMxzH5aM4K01qceLcNOsdzHlituLIYEiSFblKDRfzFSzpCfZ JLw3mru7xZDkaDbe+xBgFGmHdG2pnIeYoU2ih1TPjlc4yNeSM4kWmXDYE2Gq7jEqG0xH 27Hc1XeCpSp7/ywR1SqatJD5GxUNcYNORzoA/jBo9NO88q5rWz7R0TD+FHV5xjRyQgfE aVVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=IkzHvE2MjcT5CaQKY7CS4Qpfvx8aXUR2/xO88KdGfvM=; b=SObrf7CxRQjWHY3+0ExKA1THyqtnkwNAIcdEKciSiuSgsys0WvwUfOx69OOZATtFff DLrc3BHp7Q/+sWv3WoZwp4Ajp9HoFDqbfk/MHlOy1wjdwqOmXYtO3X2PAiCCSF6LupJ5 ipCpV7IW/SdenrHVxXsl7jA6q4OGiIyRN50lSSAHCQ8eXwnXhDVCy9x4qql6XXGXhpRv CIJu5LQNw7sFWz18Q1sAslyvVkrZ5i2BDD2ZJDLhZoGcUOIgcxG6SqZWI5KXiEOn44Hx ObO7lYX1BZ1ihASBwGNdiaR+iYSRV4cDS1a25e/2B69z3AxvjM56Zx+7l5pE5Nc/8VuD q3Vg== X-Gm-Message-State: ACrzQf2gJFgebLoys7jRL5CC53UWRiDwoC5Y80U1NFmGGTHSEM6K+v3K mUgZsuxK9bVGN4InBbSZSUo= X-Google-Smtp-Source: AMsMyM6ujInirvat2IAFsidWKzWccX96AEv/qY6OKcVxq3nT9uoXX9dIIh1fxuTNkm+EWpMdW4hKwQ== X-Received: by 2002:a05:6a00:9a9:b0:541:787f:f2c with SMTP id u41-20020a056a0009a900b00541787f0f2cmr8649373pfg.12.1664535986035; Fri, 30 Sep 2022 04:06:26 -0700 (PDT) Received: from generichostname (136-25-1-99.cab.webpass.net. [136.25.1.99]) by smtp.gmail.com with ESMTPSA id c16-20020a170902d49000b0017870f471f6sm1624005plg.226.2022.09.30.04.06.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 04:06:25 -0700 (PDT) Date: Fri, 30 Sep 2022 04:06:22 -0700 From: Denton Liu To: Oskari Pirhonen Cc: The development of GNU GRUB , Daniel Kiper Subject: Re: [RESEND RESEND RESEND PATCH] templates: introduce GRUB_TOP_LEVEL_* vars Message-ID: References: <20220921112225.145616-1-liu.denton@gmail.com> <20220927123045.100271-1-liu.denton@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::534; envelope-from=liu.denton@gmail.com; helo=mail-pg1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2022 11:06:29 -0000 Hi Oskari, On Fri, Sep 30, 2022 at 01:53:59AM -0500, Oskari Pirhonen wrote: > > I'm not too familiar with what end-users might want. If we want to make > > this more universal, we could either do GRUB_TOP_LEVEL_KERNEL and have > > that shared amongst all of the 10_* files or we could have multiple > > variables, e.g. GRUB_TOP_LEVEL_LINUX, GRUB_TOP_LEVEL_BSD, etc. > > > > A single GRUB_TOP_LEVEL or something is what I was thinking. I'm not > familiar with Xen, but based on your original patch, it may warrant its > own. I'm not familiar with Xen either. My understanding is that there can be parallel top-level entries so it deserves its own variable. > > > - What about for os-prober? My understanding is that it creates its own > > > top level entries as well. > > > > The same thing could work with os-prober, although it wouldn't be a > > cut-and-paste. > > > > os-prober would probably have its own GRUB_TOP_LEVEL_OS_PROBER or > something as well. Sounds good! > > I'm open to all ideas here and I can cook up the patches. The thing is > > that I'm not sure what the project's conventions are regarding > > too-granular/not-granular-enough configurations so some advice here > > would be very much appreciated! > > > > Generating a config for multiple OS's would use os-prober, so a single > "main" variable for top level entries would be simpler and should be > enough IMO. Thanks for the feedback! Patch coming soon. -Denton