Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13D33C35FFF for ; Fri, 21 Mar 2025 11:18:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tvaNY-0001S9-N5; Fri, 21 Mar 2025 07:17:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tvaNM-0001RY-9V for qemu-devel@nongnu.org; Fri, 21 Mar 2025 07:17:20 -0400 Received: from ssh.movementarian.org ([139.162.205.133] helo=movementarian.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tvaNJ-0000Ha-SF for qemu-devel@nongnu.org; Fri, 21 Mar 2025 07:17:20 -0400 Received: from movement by movementarian.org with local (Exim 4.95) (envelope-from ) id 1tvaNC-0025nI-Lh; Fri, 21 Mar 2025 11:17:10 +0000 Date: Fri, 21 Mar 2025 11:17:10 +0000 From: John Levon To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: qemu-devel@nongnu.org, Alex Williamson , Avihai Horon , Eric Auger , Zhenzhong Duan Subject: Re: [PATCH for-10.1 15/32] vfio: Introduce a new header file for helper services Message-ID: References: <20250318095415.670319-1-clg@redhat.com> <20250318095415.670319-16-clg@redhat.com> <54970125-0f63-40cc-9c4a-540cf82a2ae8@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54970125-0f63-40cc-9c4a-540cf82a2ae8@redhat.com> X-Url: http://www.movementarian.org/ Received-SPF: pass client-ip=139.162.205.133; envelope-from=movement@movementarian.org; helo=movementarian.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Mar 21, 2025 at 10:25:15AM +0100, Cédric Le Goater wrote: > > > +struct vfio_info_cap_header * > > > +vfio_get_region_info_cap(struct vfio_region_info *info, uint16_t id); > > > > This can be static in fact. > > It is used by vfio_device_get_region_info_type() and > vfio_device_has_region_cap(). OK; I was being lazy and didn't check the source tree at this point. thanks john