Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3CFEC28B30 for ; Thu, 20 Mar 2025 09:47:25 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tvCUZ-0008PW-5Q; Thu, 20 Mar 2025 05:47:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tvCUI-0008Nk-6m for qemu-devel@nongnu.org; Thu, 20 Mar 2025 05:46:57 -0400 Received: from ssh.movementarian.org ([139.162.205.133] helo=movementarian.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tvCUG-0003Ju-Rh for qemu-devel@nongnu.org; Thu, 20 Mar 2025 05:46:53 -0400 Received: from movement by movementarian.org with local (Exim 4.95) (envelope-from ) id 1tvCUE-001heR-HW; Thu, 20 Mar 2025 09:46:50 +0000 Date: Thu, 20 Mar 2025 09:46:50 +0000 From: John Levon To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: qemu-devel@nongnu.org, Alex Williamson , Avihai Horon , Eric Auger , Zhenzhong Duan Subject: Re: [PATCH for-10.1 24/32] vfio: Introduce new files for dirty tracking definitions and declarations Message-ID: References: <20250318095415.670319-1-clg@redhat.com> <20250318095415.670319-25-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250318095415.670319-25-clg@redhat.com> X-Url: http://www.movementarian.org/ Received-SPF: pass client-ip=139.162.205.133; envelope-from=movement@movementarian.org; helo=movementarian.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Mar 18, 2025 at 10:54:07AM +0100, Cédric Le Goater wrote: > File "common.c" has been emptied of most of its definitions by the > previous changes and the only definitions left are related to dirty > tracking. Rename it to "dirty-tracking.c" and introduce its associated > "dirty-tracking.h" header file for the declarations. > > Cleanup a little the includes while at it. > > Signed-off-by: Cédric Le Goater > rename from hw/vfio/common.c > rename to hw/vfio/dirty-tracking.c > index ed2f2ed8839caaf40fabb0cbbcaa1df2c5b70d67..441f9d9a08c06a88dda44ef143dcee5f0a89a900 100644 > --- a/hw/vfio/common.c > +++ b/hw/vfio/dirty-tracking.c > @@ -20,14 +20,10 @@ I think you might want to update the file comment from "generic functions used by VFIO devices". regards john