Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66223C6FD1C for ; Thu, 23 Mar 2023 12:05:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZBP2lII8vRLgS5VW24uiAbk0Lp4AX4TcB4aSkoFMaIU=; b=Sz9exCM0ZTqvB6nxFaDUPLibQf FfP1hkgZcsuPXSinarXyMLLYM7i8iItB7sbMvNkFTTEMH74GlR55vOdr09BEzIQ+feeUnLsQ/VIjr i2xpwAzcVUmwl55qEeiMQMfzBq8c8+eN9DUriDWBnvyZafaAxAdudqfKBeBeGY1snp8xrC2hz0JCi NEP5QxhRUQ/09dJcgJZXzwLwPuNSpKlLSZkY/xFESumdmyWRqS1m1FitlrHQne9CNTDxlg03YBduE 7lGvpbVSp8f2gu5mYV8dht7hLibCQXll/x9qxnQ0ipybIiH8v1Cu+mKyAgnMzhHpuj2pDCM+1p/sq tF7dWefA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pfJgh-001pjA-0K; Thu, 23 Mar 2023 12:04:59 +0000 Received: from jabberwock.ucw.cz ([46.255.230.98]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfJgd-001phl-2X for linux-arm-kernel@lists.infradead.org; Thu, 23 Mar 2023 12:04:57 +0000 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 4576E1C0E49; Thu, 23 Mar 2023 13:04:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1679573094; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a/KoMv72J5IIz0NM8GNmcSDXPLFS3Vkv0wZ+gg3A9vc=; b=D3RWeS7ZzdCwgmaip0tK7qF1pk+0eq9crqm8wlRLN0VwU4ch5LoLGN9GkYiUKbHStOHQG5 ip72ixYlxxhVXDeZWurv7JvDnzYRhY38H53HaSB392q1stZiSOrW5vqP4OKqBXNebHqlHi jS7wZujiZ36L/6mjm/7tRHZFq4pMD+4= Date: Thu, 23 Mar 2023 13:04:53 +0100 From: Pavel Machek To: Christian Marangi Cc: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [net-next PATCH v5 15/15] arm: mvebu: dt: Add PHY LED support for 370-rd WAN port Message-ID: References: <20230319191814.22067-1-ansuelsmth@gmail.com> <20230319191814.22067-16-ansuelsmth@gmail.com> MIME-Version: 1.0 In-Reply-To: <20230319191814.22067-16-ansuelsmth@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230323_050455_968247_ED5878E2 X-CRM114-Status: GOOD ( 14.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0848647157524490306==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0848647157524490306== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PW0UYIpUfo2k2zdg" Content-Disposition: inline --PW0UYIpUfo2k2zdg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > From: Andrew Lunn >=20 > The WAN port of the 370-RD has a Marvell PHY, with one LED on > the front panel. List this LED in the device tree. >=20 > Signed-off-by: Andrew Lunn > Signed-off-by: Christian Marangi > @@ -135,6 +136,19 @@ &mdio { > pinctrl-names =3D "default"; > phy0: ethernet-phy@0 { > reg =3D <0>; > + leds { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + led@0 { > + reg =3D <0>; > + label =3D "WAN"; > + color =3D ; > + function =3D LED_FUNCTION_LAN; > + function-enumerator =3D <1>; > + linux,default-trigger =3D "netdev"; > + }; > + }; > }; > =20 How will this end up looking in sysfs? Should documentation be added to Documentation/leds/leds-blinkm.rst ? BR, Pavel --=20 People of Russia, stop Putin before his war on Ukraine escalates. --PW0UYIpUfo2k2zdg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZBxAZQAKCRAw5/Bqldv6 8pImAJ980SFJLWibENGuBRgkO7NwT1wjugCguwbshHgsV+9S/7u61KaJxx8XEEA= =1SzX -----END PGP SIGNATURE----- --PW0UYIpUfo2k2zdg-- --===============0848647157524490306== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0848647157524490306==--