Date: Tue, 28 Mar 2023 13:19:11 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
	Baolu Lu <baolu.lu@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	Joerg Roedel <joro@8bytes.org>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	"vkoul@kernel.org" <vkoul@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>, Will Deacon <will@kernel.org>,
	David Woodhouse <dwmw2@infradead.org>,
	"Raj, Ashok" <ashok.raj@intel.com>,
	"Liu, Yi L" <yi.l.liu@intel.com>,
	"Yu, Fenghua" <fenghua.yu@intel.com>,
	"Jiang, Dave" <dave.jiang@intel.com>,
	"Luck, Tony" <tony.luck@intel.com>,
	"Zanussi, Tom" <tom.zanussi@intel.com>
Subject: Re: [PATCH v2 7/8] iommu: Export iommu_get_dma_domain
Message-ID: <ZCMTf5RwebmELsoT@nvidia.com>
References: <20230327232138.1490712-1-jacob.jun.pan@linux.intel.com>
 <20230327232138.1490712-8-jacob.jun.pan@linux.intel.com>
 <e7d53d04-6b7f-05a4-3077-42470c6d2823@linux.intel.com>
 <BN9PR11MB527623AC2CE25EDA10FF81548C889@BN9PR11MB5276.namprd11.prod.outlook.com>
 <20230328084822.4b46e649@jacob-builder>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230328084822.4b46e649@jacob-builder>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Y6xMrueGo1P4YOAw9OdkFX905+rV3U3p8NY2/5dC/PXWlSbOg/Dr2Ftq+PjW?=
 =?us-ascii?Q?wGKHgjmxiA2JwJPnyP76wwLVKkPETUUsrwvX4sRZekCNcmpaxbfBI1SVQNir?=
 =?us-ascii?Q?y8Sq1z1VZCOUC8qJmBS4OQ1R1nOsC4ESniIWTmXQAZA5VXQJpA3bBY48I2SS?=
 =?us-ascii?Q?Oe+nTfNE2GvCpl7IRPnkJfM9fhyv25gMqK26uUDYV3tN5pY6jMIxOhxxcizs?=
 =?us-ascii?Q?Li1/VskhFLLPwta0k/atKqk04rH9nsTeF7boyXMqZ65ot/8Fr0aug0Y+dnMc?=
 =?us-ascii?Q?e/jIHub3CIN28Cu+5O043u1elvZ3ooushFf2GxBvK6IM8ajS+zQG5OczXd1+?=
 =?us-ascii?Q?YFH3/VZh80mtF4TPbZiesBU7T9Sr664x5Cwq+Ww/74ZI3INq3afPzgEnNSNt?=
 =?us-ascii?Q?O5M0tuggvmB8sIzl0MzfiP7vywpUKLrMz6b+V6aW6eqSEXAqlfoXCYvcm7DR?=
 =?us-ascii?Q?SBraNBS8J/DxuWuj3jkx4PaioZIxQGh6lyEDdTPzlGnBUrWLGY0L85FlsplD?=
 =?us-ascii?Q?p07QFlPQHWHlfY3SHHRB1nL7TUpxofsj+uxT6jZOs1BnkOMeGqNwxP1N8jAT?=
 =?us-ascii?Q?w2KOI93y+jXQTdF6KExJNsXSBlFBrW2EXP6MMkoHCXDy8N5VjCiBIrP5XtM1?=
 =?us-ascii?Q?DsVoPuh6GAp5syNYkdLvOcz5UUGh5yGJsh2ahJ3b3vopV/G3KT2QQ59lutSq?=
 =?us-ascii?Q?+DXqU8jStWgFlzHuku1ZpnvuUVf1ogNb+l6jZ7T8uimDPrzuV349KlOQcRVW?=
 =?us-ascii?Q?vvdYW6Tzz542wzkPRk+ZWTDglJr6cu/piBTpoljiJ8A6gr9O8hKHUoqKFKxR?=
 =?us-ascii?Q?oMbVJ7zpb/fr0yGChD1cYdg/vbRSctQoj5Jhb50gZ2DIiV8taKXorXebMH7P?=
 =?us-ascii?Q?OBI+2X21MjV3pQopZUN1kLZ024/sJc4AdkTfnz+ybDqMUCrYjb+zJuPwmDOs?=
 =?us-ascii?Q?A4smCz9yo38STMBiI3wdATeHcCzXEUnt+Mf9pskJkb3Jpo0Ro8FjDVeFIuqi?=
 =?us-ascii?Q?Eh4+esREbqEfW76N7VW7ljoWMJMlud+tat7QsBf78K5PKImvfi41RQfeYnBi?=
 =?us-ascii?Q?dOSyeSLrz3Q3MWb66AR5w3TJRy9GDXL4OS26+9hoJfy0eJ1bLZlsJ1X3at1V?=
 =?us-ascii?Q?Z8rOA0jcU+NOoARag9RRwu68gA3iNumH+CNqWVTaShoLIWCjj78lHEPyQJYt?=
 =?us-ascii?Q?3XMwtkJXKzX/KCO+n1Nm4w5TdTboGIBZ5XL11dgMqmwORralRUCrizGH1l7U?=
 =?us-ascii?Q?x3Qk9j1CXVnT4bhx8vLKVZk3nfWLEqQgTUz5pwKCo99YobewQKm3kGzl2lLz?=
 =?us-ascii?Q?wHPWl/YjnuJrbq39ylMob+fD+fJX6k0y640i/c6zipkp+78LBRbNrgRWdtaU?=
 =?us-ascii?Q?PBcNSRbvke7lW2SqyLVm6x3OWhxdr/bF/9O0pt3rYQ3h6HL0fWOv1B18zuQS?=
 =?us-ascii?Q?tHKUkeXbcw4QQRl7NzinvQV+r4dCRWArJQ4vEUbYQOLXfPPZ9UpLUnc2tfQ0?=
 =?us-ascii?Q?QMv5rF7u7UIWAaOhpsBx50y8up2UYSO4VlyWoOckTDffmUvjFq5khxlecQuP?=
 =?us-ascii?Q?3x9ZpRgd7FhBNkIHv7MfdayvR/wzSLGcdmyRpYer?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 41227b94-e5d4-4b9d-fae1-08db2fa82bc9
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2023 16:19:14.0600
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 32O/DbFoVENXqefh5t4bi5eW4130IPaZV57AEs9ZbZnhFDn6cDo23yyzGPAPzRAI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8289

On Tue, Mar 28, 2023 at 08:48:22AM -0700, Jacob Pan wrote:

> > Agree. The kernel driver managing the device wants to get the current 
> > domain of the device then iommu_get_domain_for_dev() is the right
> > interface. It knows the domain is the dma domain.
> This goes back to v1 then :)
> 
> I thought the comments from v1 is that we don't want to check the domain
> type is DMA domain returned by iommu_get_domain_for_dev()
> 
> If the driver "knows" the domain is dma domain, why can't it use
> iommu_get_dma_domain()? seems paradoxical.

Huh?

The DMA API operates on the current domain of the device, be it
IDENTITY or UNMANAGED.

You have to copy whatever the current domain is to the PASID and you
should definately not check if it is DMA or something.

Jason