Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC3D5C76196 for ; Tue, 28 Mar 2023 23:51:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229567AbjC1XvL (ORCPT ); Tue, 28 Mar 2023 19:51:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbjC1XvK (ORCPT ); Tue, 28 Mar 2023 19:51:10 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C7332D47 for ; Tue, 28 Mar 2023 16:50:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Rf0i3Hx3Ehzoe72CAg0C58+n/MAWqC4CMGqWmLMKTaQ=; b=H/23p6qwFiLqjK3P/mOzVaH6OG vTfM+6Ko/AQSM6K3qTYRO/1WrhorhJOgw9DfZ+pMp9LPL5i/Breu+T1xvZsXDc4Zn37PVtYq/SIco ibXN0GJtuxHNFRQdhiyMoFekysyoeP0hsTIqlR7MWX1FxZyUrOuEBLMJ6QegF6X7Vw4Ts9zymtjWp rLvUy8mLyEw4QyCY36jsJ42GB6KCpz9fU35H4xc4wdYifQ4KRz+mEhzd73PVInE1RLilVwBS7Z/Q5 EfApye7HxHTaozoXqq6KX9jkp8dIAE77STeeHkdloneN9yw7CDGLgeyy8EcxsH3n6UVIa/8NTBnbu GqURggbQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1phJ5a-00G93R-2r; Tue, 28 Mar 2023 23:50:54 +0000 Date: Tue, 28 Mar 2023 16:50:54 -0700 From: Christoph Hellwig To: Qu Wenruo Cc: Christoph Hellwig , Qu Wenruo , linux-btrfs@vger.kernel.org Subject: Re: [PATCH v2 00/12] btrfs: scrub: use a more reader friendly code to implement scrub_simple_mirror() Message-ID: References: <2dfc49ef-e041-3efd-1c55-3685df22acb6@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Mar 29, 2023 at 07:44:59AM +0800, Qu Wenruo wrote: > Isn't the patch split also important? > > Anyway I will try some different methods to split that. I'll have to defer to David as btrfs is sometimes a little different from the rest of the kernel in it's requirements, but everywhere else a patch that just removes code can be as big as it gets.