Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61045C77B75 for ; Tue, 18 Apr 2023 06:52:44 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pofBo-00063f-CU; Tue, 18 Apr 2023 02:51:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pofBm-00063R-QS; Tue, 18 Apr 2023 02:51:42 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pofBi-0005oY-41; Tue, 18 Apr 2023 02:51:42 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 203C55C0079; Tue, 18 Apr 2023 02:51:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 18 Apr 2023 02:51:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1681800695; x= 1681887095; bh=GQATokZxCQMENbOrFc6bac2aPHAdok84LG107OhOWzY=; b=v lVQxZPskqjTbxGKmaEem5+Mus/bj1RxaYlNrKGaPG6zkVTi2TkFwmGeqgWpGBLOm D9MCsbh8gTc0FvV5y1Lf6GBuVZj2ebwah4fPgK+DGQWYrRH7J2PCdIOY4T0U9dbw U0fKqcHIpkll+wIlhXxFGNtQFWtdFYXucdxYItThPzlXEPnuJ5fUc5J8yNTntVCp /0WlKMjML0JTnoOlbW6NOwt2ow6OJ3uA5Tawf9kQIGAJfAlSTiQGhkPZjDET79oH sHzmN02SYO3BiPs2cFT4DO0Gcec1Sq+EYhxwHc6Ey0O2R04Bo9L6/5/vzdu6Bo6h zVwpL6dJO01hQERiOKv8g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1681800695; x=1681887095; bh=GQATokZxCQMEN bOrFc6bac2aPHAdok84LG107OhOWzY=; b=DRK0svYkhRSoyPdXpmNdI4ln1cdAZ ahfpBtDcKEbnrjmKnKEkG2q4ikRUXkiN+bR6XSGqUPfVgD9YbDCCzKc+LiUx24AI X4/AAqEicI9kct8JQ1+xnXsZm8h6TeOuHrLdkMihqNT7pvvmEWCBADZPiViloQpr vOTKbmPQOS9MxAMiAJFYTkgGWz3+YjMMIWlHCBmwIH/Up0sZy2qPx3qzcaZdOvG/ RW28h95zjz2P4RxKHOkpuYKm+xXqgVdqQOgIM0r28jq/3iM7/38BsG01wfFw7M9i KQsRz3X+21krFNIGW6fFRw6t9eMjWake3HopyMqsgW8/CNz0TAcw6zQ7g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeljedgudduhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpefmlhgr uhhsucflvghnshgvnhcuoehithhssehirhhrvghlvghvrghnthdrughkqeenucggtffrrg htthgvrhhnpeejgfejfeffvdeuhfeifefhgffgueelhedukeevjeevtdduudegieegteff ffejveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hithhssehirhhrvghlvghvrghnthdrughk X-ME-Proxy: Feedback-ID: idc91472f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 18 Apr 2023 02:51:32 -0400 (EDT) Date: Tue, 18 Apr 2023 08:51:31 +0200 From: Klaus Jensen To: Minwoo Im Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Keith Busch , Minwoo Im , Klaus Jensen Subject: Re: [PATCH] hw/nvme: add comment for nvme-ns properties Message-ID: References: <20230418002025.29232-1-minwoo.im.dev@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zWTtYKCpx1WlpPGf" Content-Disposition: inline In-Reply-To: <20230418002025.29232-1-minwoo.im.dev@gmail.com> Received-SPF: pass client-ip=66.111.4.28; envelope-from=its@irrelevant.dk; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --zWTtYKCpx1WlpPGf Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Apr 18 09:20, Minwoo Im wrote: > From: Minwoo Im >=20 > Add more comments of existing properties for nvme-ns device. >=20 > Signed-off-by: Minwoo Im > Reviewed-by: Klaus Jensen > --- > hw/nvme/ctrl.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c > index 8b7be14209..87c07f5dbb 100644 > --- a/hw/nvme/ctrl.c > +++ b/hw/nvme/ctrl.c > @@ -43,7 +43,14 @@ > * subsys=3D > * -device nvme-ns,drive=3D,bus=3D,nsid=3D,\ > * zoned=3D, \ > - * subsys=3D,detached=3D > + * subsys=3D,shared=3D, \ > + * detached=3D, \ > + * zoned.zone_size=3D, \ > + * zoned.zone_capacity=3D, \ > + * zoned.descr_ext_size=3D, \ > + * zoned.max_active=3D, \ > + * zoned.max_open=3D, \ > + * zoned.cross_read=3D > * > * Note cmb_size_mb denotes size of CMB in MB. CMB is assumed to be at > * offset 0 in BAR2 and supports only WDS, RDS and SQS for now. By defau= lt, the > --=20 > 2.34.1 >=20 Thanks, Applied to nvme-next! --zWTtYKCpx1WlpPGf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmQ+PfIACgkQTeGvMW1P DelOZQf/Q7OKbFN453Y8pakb6ljitAr6zIQzlBzP0GmyP75JdR+07KZg6bWAn7wD nT6fxKdzDpNEOoCftu+GtZBhpsEZMCC/tDi7n7Nxjv/EPgXe56wkqLexmenmYQSg 5gVKIng1FFdnNHEtIP4IK6TF0b+GnSb43QosTsiUemD1RiPHDPhk6N0pLSq/SvOR fb8NyAqU/i8LqjXrktujl9kiMVw9K3yjicllSnsSOD5cTG4HjOoQO+sipEt+LuYE fAymC87xtOMeIOsDL8hRNDoPPIu/TSUE8WCmwZMNQZ0QBqnsBa8TmMi97tqWccSX L3C3+c9CBSTHWZlTKCRLnq7Ac5gdXg== =sxYl -----END PGP SIGNATURE----- --zWTtYKCpx1WlpPGf--