Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B49B0C77B75 for ; Tue, 18 Apr 2023 11:54:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pojuK-0008Ms-V8; Tue, 18 Apr 2023 07:54:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pojuJ-0008Me-Cd for qemu-devel@nongnu.org; Tue, 18 Apr 2023 07:53:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pojuH-0004X3-PS for qemu-devel@nongnu.org; Tue, 18 Apr 2023 07:53:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681818837; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=f1UDzOa8Miqp1ttvF+ikWN3q1qrjzAHYFKsKMEPQzto=; b=e5LKI5MDaJB0rW6HoJQYaCC/p1qoI1uWnZDLUQ7GI/PzBsCIVz0kMx/MWvCXyC4xug9/LY 2NhLgadO2Bc0V79BVVJ1uOzgouCy5LFIqFvDCT6CKC1OMYVdq2+yHjyCeSpstVPzbclba9 R8nPdIoTKEkcG7KZeLCV2FEjF7PAjpg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-158-FnPaAE15OSOiHCIPp6cBBQ-1; Tue, 18 Apr 2023 07:53:55 -0400 X-MC-Unique: FnPaAE15OSOiHCIPp6cBBQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4CFCE801779 for ; Tue, 18 Apr 2023 11:53:55 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 89E4420239E0; Tue, 18 Apr 2023 11:53:54 +0000 (UTC) Date: Tue, 18 Apr 2023 12:53:52 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Juan Quintela Cc: qemu-devel@nongnu.org, Paolo Bonzini , Laurent Vivier , Thomas Huth Subject: Re: [PATCH 1/2] tests/migration: Make precopy fast Message-ID: References: <20230412142001.16501-1-quintela@redhat.com> <20230412142001.16501-2-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230412142001.16501-2-quintela@redhat.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Apr 12, 2023 at 04:20:00PM +0200, Juan Quintela wrote: > Otherwise we do the 1st migration iteration at a too slow speed. > > Signed-off-by: Juan Quintela > --- > tests/qtest/migration-test.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c > index 3b615b0da9..7b05b0b7dd 100644 > --- a/tests/qtest/migration-test.c > +++ b/tests/qtest/migration-test.c > @@ -1348,6 +1348,7 @@ static void test_precopy_common(MigrateCommon *args) > migrate_qmp(from, args->connect_uri, "{}"); > } > > + migrate_ensure_converge(from); This isn't right - it defeats the point of having the call to migrate_ensure_non_converge() a few lines earlier. > if (args->result != MIG_TEST_SUCCEED) { > bool allow_active = args->result == MIG_TEST_FAIL; > @@ -1365,8 +1366,6 @@ static void test_precopy_common(MigrateCommon *args) > wait_for_migration_pass(from); > } > > - migrate_ensure_converge(from); > - The reason why we had it here was to ensure that we test more than 1 iteration of migration. With this change, migrate will succeed on the first pass IIUC, and so we won't be exercising the more complex code path of repeated iterations. I do agree with the overall idea though. We have many many migration test scenarios and we don't need all of them to be testing multiple iterations - a couple would be sufficient. In fact we don't even need to be testing live migration for most of the cases. All the TLS test cases could be run with guest CPUs paused entirely removing any dirtying, since they're only interested in the initial network handshake/setup process testnig. I had some patches I was finishing off just before I went on vacation a few weeks ago which do this kind of optimization, which I can send out shortly. > /* We do this first, as it has a timeout to stop us > * hanging forever if migration didn't converge */ > wait_for_migration_complete(from); With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|