Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 791E6C77B61 for ; Thu, 13 Apr 2023 14:10:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D26110E167; Thu, 13 Apr 2023 14:10:33 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1DCFC10E167; Thu, 13 Apr 2023 14:10:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681395031; x=1712931031; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=iN/wSUBRfn/KK3ga/Tp92Uhf2wOodlG12auRetLJGKU=; b=hw7MrBhOjCXM3bFuGy0TelvagLBUoRPvcoaA4zJU/3E7DAd274VH3yON piYWB51/Aq2UKRrMbwUzAw6QB3loVVVEQAw8MYzkEs02/u5KH2Jg+Z3lJ TPFAS4uZgk97qjLcunWjlbdE/jLM0lyZmiOdegyKaPOL/fHV+iC64Fi3b X9YT8TQ1IlIoapY5NecANwZLiMwD2cl90fGwyR8jvfqHBBbQVwgOQBwDJ svxNLWWwXq3YYJG+L956BsufKN3wOGA4+KPMPXM1GD0hagaGCv4kNw06f w7IPiBC2DBbsCyM7skcegJGeJS27+9Qa7opec8aR6gOlVL2nwoJUVUj6+ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10679"; a="332920444" X-IronPort-AV: E=Sophos;i="5.99,193,1677571200"; d="scan'208";a="332920444" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2023 06:56:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10679"; a="682959859" X-IronPort-AV: E=Sophos;i="5.99,193,1677571200"; d="scan'208";a="682959859" Received: from zbiro-mobl.ger.corp.intel.com (HELO intel.com) ([10.251.212.144]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2023 06:56:48 -0700 Date: Thu, 13 Apr 2023 15:56:21 +0200 From: Andi Shyti To: Tvrtko Ursulin Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Make IRQ reset and postinstall multi-gt aware Message-ID: References: <20230413092006.931861-1-andi.shyti@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andi Shyti , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Daniele Ceraolo Spurio , Andi Shyti , Nirmoy Das , Matt Roper , Paulo Zanoni Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Tvrtko, (I forgot to CC Daniele) On Thu, Apr 13, 2023 at 11:41:28AM +0100, Tvrtko Ursulin wrote: > > On 13/04/2023 10:20, Andi Shyti wrote: > > From: Paulo Zanoni > > > > In multitile systems IRQ need to be reset and enabled per GT. > > > > Although in MTL the GUnit misc interrupts register set are > > available only in GT-0, we need to loop through all the GT's > > in order to initialize the media engine which lies on a different > > GT. > > > > Signed-off-by: Paulo Zanoni > > Cc: Tvrtko Ursulin > > Signed-off-by: Andi Shyti > > --- > > Hi, > > > > proposing again this patch, apparently GuC needs this patch to > > initialize the media GT. > > What is the resolution for Matt's concern that this is wrong for MTL? There are two explanations, one easy and one less easy. The easy one: without this patch i915 doesn't boot on MTL!(*) The second explanation is that in MTL the media engine has it's own set of misc irq's registers and those are on a different GT (Daniele pointed this out). I sent this patch not to bypass any review, but to restart the discussion as this patch was just dropped. Thanks, Andi (*) [drm] *ERROR* GT1: GUC: CT: No response for request 0x550a (fence 7) [drm] *ERROR* GT1: GUC: CT: Sending action 0x550a failed (-ETIMEDOUT) status=0X0 [drm] *ERROR* GT1: GUC: Failed to enable usage stats: -ETIMEDOUT [drm] *ERROR* GT1: GuC initialization failed -ETIMEDOUT [drm] *ERROR* GT1: Enabling uc failed (-5) [drm] *ERROR* GT1: Failed to initialize GPU, declaring it wedged!