Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58D0BC77B7C for ; Mon, 24 Apr 2023 08:31:13 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqraZ-0004PJ-Le; Mon, 24 Apr 2023 04:30:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqraY-0004P1-Bi for qemu-devel@nongnu.org; Mon, 24 Apr 2023 04:30:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqraT-0006qi-JM for qemu-devel@nongnu.org; Mon, 24 Apr 2023 04:30:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682325016; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=8JZ+mLm8RRU9AWbdZl8OOvABT0Ax/knGRb14w2s6f+g=; b=PPxUsUxaDtJiUZgbPKT7AGxPj1NMnT4m/OhdTLiKCv2CO+GAINXDqRm9SbKx4VRH6c58Eq 08By3eXVQZb6UO2D0ZTcA6oZ/qFuXiQP4gMECDqNySRmDqmt4K29JGlHCf5UzjMloDYkvD eQgdOS+MvHissw0seJlPEq7wpSWqc7k= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-517-v_w2lqgwOriLzQQv3fg4-Q-1; Mon, 24 Apr 2023 04:30:12 -0400 X-MC-Unique: v_w2lqgwOriLzQQv3fg4-Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E948185C07A; Mon, 24 Apr 2023 08:30:11 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 213CD2027043; Mon, 24 Apr 2023 08:30:10 +0000 (UTC) Date: Mon, 24 Apr 2023 09:30:07 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Karim Taha Cc: qemu-devel@nongnu.org, imp@bsdimp.com Subject: Re: [PATCH v4 01/11] Signed-off-by: Karim Taha Message-ID: References: <20230421165351.3177-1-kariem.taha2.7@gmail.com> <20230421165351.3177-2-kariem.taha2.7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230421165351.3177-2-kariem.taha2.7@gmail.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.172, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org You've not fully addressed the feedback on v3. The first line of the commit message needs to be a short sumary, not the Signed-off-by, which should be at the end of the commit message On Fri, Apr 21, 2023 at 06:53:41PM +0200, Karim Taha wrote: > From: Warner Losh > > Intialize guest_base in bsd-user/main.c. > > Allow guest_base to be initialized on 64-bit hosts, the initial value is used by g2h_untagged function defined in include/exec/cpu_ldst.h You also need to put line breaks in the commit message to keep it at around 72 chars > > Signed-off-by: Warner Losh > Signed-off-by: Karim Taha > --- > bsd-user/main.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/bsd-user/main.c b/bsd-user/main.c > index babc3b009b..afdc1b5f3c 100644 > --- a/bsd-user/main.c > +++ b/bsd-user/main.c > @@ -50,8 +50,22 @@ > #include "target_arch_cpu.h" > > int singlestep; > -uintptr_t guest_base; > + > +/* > + * Going hand in hand with the va space needed (see below), we need > + * to find a host address to map the guest to. Assume that qemu > + * itself doesn't need memory above 32GB (or that we don't collide > + * with anything interesting). This is selected rather arbitrarily, > + * but seems to produce good results in tests to date. > + */ > +# if HOST_LONG_BITS >= 64 > +uintptr_t guest_base = 0x800000000ul; /* at 32GB */ > +bool have_guest_base = true; > +#else > +uintptr_t guest_base; /* TODO: use sysctl to find big enough hole */ > bool have_guest_base; > +#endif > + > /* > * When running 32-on-64 we should make sure we can fit all of the possible > * guest address space into a contiguous chunk of virtual host memory. > -- > 2.40.0 > > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|