Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 777F6C77B61 for ; Fri, 28 Apr 2023 06:35:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345270AbjD1GfB (ORCPT ); Fri, 28 Apr 2023 02:35:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345142AbjD1Ge7 (ORCPT ); Fri, 28 Apr 2023 02:34:59 -0400 Received: from mail.kevlo.org (mail.kevlo.org [220.134.220.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C0692735 for ; Thu, 27 Apr 2023 23:34:57 -0700 (PDT) Received: from localhost (ns.kevlo.org [local]) by ns.kevlo.org (OpenSMTPD) with ESMTPA id 5130a7f6; Fri, 28 Apr 2023 14:34:54 +0800 (CST) Date: Fri, 28 Apr 2023 14:34:54 +0800 From: Kevin Lo To: Kalle Valo Cc: linux-wireless@vger.kernel.org, Bitterblue Smith , Jes Sorensen , Ping-Ke Shih Subject: Re: [PATCH v2] wifi: rtl8xxxu: 8188f: no need to initialize interrupts Message-ID: References: <87ildgpnsd.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ildgpnsd.fsf@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, Apr 28, 2023 at 08:40:34AM +0300, Kalle Valo wrote: > > Kevin Lo writes: > > > There's no need to initialize interrupts for RTL8188FTV like the vendor driver. > > > > Signed-off-by: Kevin Lo > > Why do this, what's the benefit? Or is this just a theoretical fix. The > commit log should explain this. If I understand correctly, just like rtw88 usb devices, rtl8xxxu has no hardware interrupt.