Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5260AC77B7C for ; Fri, 5 May 2023 13:47:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 183F810E600; Fri, 5 May 2023 13:47:17 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 492F910E600 for ; Fri, 5 May 2023 13:47:15 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5A4F063E03; Fri, 5 May 2023 13:47:14 +0000 (UTC) Received: from rdvivi-mobl4 (unknown [192.55.54.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPSA id AB3F8C433EF; Fri, 5 May 2023 13:47:12 +0000 (UTC) Date: Fri, 5 May 2023 09:47:09 -0400 From: Rodrigo Vivi To: Nirmoy Das Message-ID: References: <20230505133433.9642-1-nirmoy.das@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230505133433.9642-1-nirmoy.das@intel.com> Subject: Re: [Intel-xe] [PATCH] drm/xe: Print GT info on TLB inv failure X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-xe@lists.freedesktop.org Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, May 05, 2023 at 03:34:33PM +0200, Nirmoy Das wrote: > Print GT info on TLB inv failure for better debugbility. > > Signed-off-by: Nirmoy Das Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c > index 604f189dbd70..9e7fe8d9bca4 100644 > --- a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c > +++ b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c > @@ -34,8 +34,8 @@ static void xe_gt_tlb_fence_timeout(struct work_struct *work) > break; > > trace_xe_gt_tlb_invalidation_fence_timeout(fence); > - drm_err(>_to_xe(gt)->drm, "TLB invalidation fence timeout, seqno=%d", > - fence->seqno); > + drm_err(>_to_xe(gt)->drm, "gt%d: TLB invalidation fence timeout, seqno=%d", > + gt->info.id, fence->seqno); > > list_del(&fence->link); > fence->base.error = -ETIME; > @@ -285,8 +285,8 @@ int xe_gt_tlb_invalidation_wait(struct xe_gt *gt, int seqno) > tlb_invalidation_seqno_past(gt, seqno), > TLB_TIMEOUT); > if (!ret) { > - drm_err(&xe->drm, "TLB invalidation time'd out, seqno=%d, recv=%d\n", > - seqno, gt->tlb_invalidation.seqno_recv); > + drm_err(&xe->drm, "gt%d: TLB invalidation time'd out, seqno=%d, recv=%d\n", > + gt->info.id, seqno, gt->tlb_invalidation.seqno_recv); > return -ETIME; > } > > -- > 2.39.0 >