Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AC40C7EE26 for ; Tue, 23 May 2023 16:30:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236315AbjEWQaL (ORCPT ); Tue, 23 May 2023 12:30:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233209AbjEWQaH (ORCPT ); Tue, 23 May 2023 12:30:07 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68EE4DD for ; Tue, 23 May 2023 09:30:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fPH9D92LiVgDrmbDXkeNFIIImZlg9QrF7WTmo1VWrAs=; b=HN53Qu5b+v9hBAQPqazNpZVoX9 cjPSxKYibk+H6PopxbfF9eh36WbPQL/YYXA9d4Vtc9f+QgEXqNszUgIKYPJEcfc5ncs5rbe+6zpjL 8Fscg4uxLcPUHFbDYy0mKzakpC5RikLBsfqkJc5aptlamOf77snJB/YPV6wOh5OsUQgpMNazq7vaD 91HUAHgT3edlRbrKFIqh8eZU+kec8th18MEshx7PlhvYK4jBxQOp+bYMxb6ONagf/dXs4MOr1341R LJNyNwG2eBMxmsQKCaSB1CWQvXS+j0evsjcagZiq0Nea4VKNMCs04Rz5oxZGOg7kKd3Sz7O3jo8ti oQJ0/V4Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q1Utg-00AntN-0k; Tue, 23 May 2023 16:30:04 +0000 Date: Tue, 23 May 2023 09:30:04 -0700 From: Christoph Hellwig To: Anand Jain Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH 2/9] btrfs: streamline fsid checks in alloc_fs_devices Message-ID: References: <5113dde5d6f756818885c39bc8ec6f5b8e45ae54.1684826247.git.anand.jain@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5113dde5d6f756818885c39bc8ec6f5b8e45ae54.1684826247.git.anand.jain@oracle.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, May 23, 2023 at 06:03:16PM +0800, Anand Jain wrote: > + ASSERT(!(fsid == NULL && metadata_fsid != NULL)); The more readable way to write this would be; ASSERT(fsid || !metadata_fsid); or just throw a ASSERT(!metadata_fsid); into the else branch of the if (fsid) check. > + if (fsid){ missing whitespace before the opening brace.