Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FB75C7EE23 for ; Wed, 7 Jun 2023 07:46:34 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.544427.850207 (Exim 4.92) (envelope-from ) id 1q6ns6-000060-ML; Wed, 07 Jun 2023 07:46:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 544427.850207; Wed, 07 Jun 2023 07:46:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q6ns6-00005t-Ix; Wed, 07 Jun 2023 07:46:22 +0000 Received: by outflank-mailman (input) for mailman id 544427; Wed, 07 Jun 2023 07:46:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q6ns5-00005n-8l for xen-devel@lists.xenproject.org; Wed, 07 Jun 2023 07:46:21 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:3::133]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 640123a6-0507-11ee-b232-6b7b168915f2; Wed, 07 Jun 2023 09:46:20 +0200 (CEST) Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q6ns0-004nZS-2l; Wed, 07 Jun 2023 07:46:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 640123a6-0507-11ee-b232-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zx7QiNnFC0Cpwen1yiSTOeTK/8rpSNjru1sqAkfYhQU=; b=yAWYaRs/exv9l4aW3kRh15uGCe 26FluPYMyAqbRNSSIKILK5H+P/HRb+mLP2AVCZD8Q6/dOrzSkIWCs7Epg5moTHRi1Pj0dpEWULnsO O7NYmBvnRZqEt+xSMqI3EI3MQfvt5yQ42VPSZsOOdcFokDphTUPA66kyZ6YO1YnkrYywoCHQYV3Ea 0MDsIqEqxuTqVM0/S2p9YhiyYiGf5LX7u3r4ZZIlUTMCZAFMMuz8srwGclvl/WuS8PZXb9qms4iiV jkrDp65eAYRHr6bzEzcpMFs/3lcXVHwIJ6nXcIQysCnXcIa9qte7v7qw+LV/9Oskk3ET3QhPsIhKZ nl2txkrA==; Date: Wed, 7 Jun 2023 00:46:16 -0700 From: Christoph Hellwig To: Demi Marie Obenour Cc: Roger Pau =?iso-8859-1?Q?Monn=E9?= , Jens Axboe , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] xen-blkback: Inform userspace that device has been opened Message-ID: References: <20230601214823.1701-1-demi@invisiblethingslab.com> <20230601214823.1701-3-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230601214823.1701-3-demi@invisiblethingslab.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html > --- a/drivers/block/xen-blkback/xenbus.c > +++ b/drivers/block/xen-blkback/xenbus.c > @@ -3,6 +3,20 @@ > Copyright (C) 2005 Rusty Russell > Copyright (C) 2005 XenSource Ltd > > +In addition to the Xenstore nodes required by the Xen block device > +specification, this implementation of blkback uses a new Xenstore > +node: "opened". blkback sets "opened" to "0" before the hotplug script > +is called. Once the device node has been opened, blkback sets "opened" > +to "1". This is a really odd comment style, and a really strange place for it. To me it feels like this should just be a file in Documentation as it relates to how to use the driver, and doesn't really explain the code.