Date: Sat, 10 Jun 2023 13:44:03 +0700
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Nicolas Escande <nico.escande@gmail.com>, nbd@nbd.name,
	Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>,
	Kalle Valo <kvalo@kernel.org>,
	Johannes Berg <johannes.berg@intel.com>
Cc: linux-wireless@vger.kernel.org,
	Linux Regressions <regressions@lists.linux.dev>
Subject: Re: [regression] STP on 80211s is broken in 6.4-rc4
Message-ID: <ZIQbs0wqdRh7c0Kx@debian.me>
References: <CT5GNZSK28AI.2K6M69OXM9RW5@syracuse>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="AnK2bowbY2wzP825"
Content-Disposition: inline
In-Reply-To: <CT5GNZSK28AI.2K6M69OXM9RW5@syracuse>


--AnK2bowbY2wzP825
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 06, 2023 at 12:55:57PM +0200, Nicolas Escande wrote:
> Hello Felix,
>=20
> As user of the mesh part of mac80211 on multiple products at work let me =
say
> thank you for all the work you do on wifi, especially on 80211s, and espe=
cially
> the recent improvements you made for mesh fast RX/TX & cross vendor AMSDU=
 compat
>=20
> We upgraded our kernel from an older (5.15) to a newer 6.4. The problem i=
s STP=20
> doesn't work anymore and alas we use it for now (for the better or worse).
>=20
> What I gathered so far from my setup:
>  - we use ath9k & ath10k
>  - in my case STP frames are received as regular packet and not as amsdu
>  - the received packets have a wrong length of 44 in tcpdump
>    (instead of 38 with our previous kernel)
>  - llc_fixup_skb() tries to pull some 41 bytes out of a 35 bytes packet
>    this makes llc_rcv() discard the frames & breaks STP
>=20
> >From bisecting the culprit seems to be 986e43b19ae9176093da35e0a844e65c8=
bf9ede7
> (wifi: mac80211: fix receiving A-MSDU frames on mesh interfaces)
>=20
> I guess that your changes to handle both ampdu subframes & normal frames =
in the
> same datapath ends up putting a wrong skb->len for STP (multicast) frames=
 ?
> Honestly I don't understand enough of the 80211 internals & spec to pinpo=
int the
> exact problem.
>=20
> It seems this change was already in the 6.3 kernel so I guess someone sho=
uld
> have seen it before (but I didn't find anything..) ? Maybe I missed somet=
hing...
>=20
> Anyway I'm happy to provide more info or try anything you throw at me.
>=20

Thanks for the regression report. I'm adding it to regzbot:

(Felix: it looks like this regression is introcued by a commit authored by =
you.
Would you like to take a look on it?)

#regzbot ^introduced: 986e43b19ae917

--=20
An old man doll... just what I always wanted! - Clara

--AnK2bowbY2wzP825
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZIQbrwAKCRD2uYlJVVFO
o6mfAPwKDa60GgI6OLmQE2Azp1jDptNJ1AD+/oDHNObrFjqZCAEAm+tAyXvMCHPG
aE8UayLKE+V/ziT/lC2I6IDiS4+f6Qs=
=Wcw6
-----END PGP SIGNATURE-----

--AnK2bowbY2wzP825--