Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D31CBA23 for ; Fri, 16 Jun 2023 12:01:15 +0000 (UTC) Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49677273F; Fri, 16 Jun 2023 05:01:12 -0700 (PDT) Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 345E22168C; Fri, 16 Jun 2023 14:01:08 +0200 (CEST) Date: Fri, 16 Jun 2023 14:01:02 +0200 From: Francesco Dolcini To: Judith Mendez Cc: Chandrasekar Ramakrishnan , Wolfgang Grandegger , Marc Kleine-Budde , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Schuyler Patton , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Oliver Hartkopp , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 4/4] DO_NOT_MERGE arm64: dts: ti: Enable MCU MCANs for AM62x Message-ID: References: <20230419223323.20384-1-jm@ti.com> <20230419223323.20384-5-jm@ti.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230419223323.20384-5-jm@ti.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Wed, Apr 19, 2023 at 05:33:23PM -0500, Judith Mendez wrote: > On AM62x there are no hardware interrupts routed to GIC interrupt > controller for MCU MCAN IP, A53 Linux cannot receive hardware > interrupts. Since an hrtimer will be used to generate software > interrupts, add MCU MCAN nodes to dtsi and default to disabled. > > AM62x does not carry on-board CAN transceivers, so instead of > changing DTB permanently use an overlay to enable MCU MCANs and to > add CAN transceiver nodes. > > If an hrtimer is used to generate software interrupts, the two > required interrupt attributes in the MCAN node do not have to be > included. > > Signed-off-by: Judith Mendez [...] > + mcu_mcan1: can@4e00000 { this should be mcu_mcan0 > + compatible = "bosch,m_can"; > + reg = <0x00 0x4e00000 0x00 0x8000>, > + <0x00 0x4e08000 0x00 0x200>; [...] > + mcu_mcan2: can@4e10000 { mcu_mcan1 > + compatible = "bosch,m_can"; > + reg = <0x00 0x4e10000 0x00 0x8000>, > + <0x00 0x4e18000 0x00 0x200>; Francesco