Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C69EEB64D9 for ; Mon, 19 Jun 2023 07:25:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4B90E846E0; Mon, 19 Jun 2023 09:24:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=tinet.cat Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 9CF7A8598A; Mon, 19 Jun 2023 09:24:57 +0200 (CEST) Received: from mx1.tinet.cat (mx1.dipta.cat [195.76.233.59]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AB7C285FD2 for ; Mon, 19 Jun 2023 09:24:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=tinet.cat Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xdrudis@tinet.cat X-ASG-Debug-ID: 1687159492-12aaf2530adb040001-4l7tJC Received: from smtp01.tinet.cat (smtp.tinet.cat [195.77.216.131]) by mx1.tinet.cat with ESMTP id BQPz5hJCDFJE8hAS; Mon, 19 Jun 2023 09:24:52 +0200 (CEST) X-Barracuda-Envelope-From: xdrudis@tinet.cat X-Barracuda-Effective-Source-IP: smtp.tinet.cat[195.77.216.131] X-Barracuda-Apparent-Source-IP: 195.77.216.131 Received: from xdrudis.tinet.cat (180.red-79-152-181.dynamicip.rima-tde.net [79.152.181.180]) by smtp01.tinet.cat (Postfix) with ESMTPSA id 48F00605DE40; Mon, 19 Jun 2023 09:24:52 +0200 (CEST) Date: Mon, 19 Jun 2023 09:24:41 +0200 From: Xavier Drudis Ferran To: u-boot@lists.denx.de Cc: Kever Yang , Simon Glass , Philipp Tomsich , Lukasz Majewski , Sean Anderson , Marek Vasut , Christoph Fritz Subject: [PATCH] phy: rockchip-inno-usb2: cleanup comments and make ops static Message-ID: X-ASG-Orig-Subj: [PATCH] phy: rockchip-inno-usb2: cleanup comments and make ops static MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Barracuda-Connect: smtp.tinet.cat[195.77.216.131] X-Barracuda-Start-Time: 1687159492 X-Barracuda-URL: https://webmail.tinet.cat:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 1896 X-Barracuda-BRTS-Status: 1 X-Barracuda-Bayes: INNOCENT GLOBAL 0.5316 1.0000 0.7500 X-Barracuda-Spam-Score: 0.75 X-Barracuda-Spam-Status: No, SCORE=0.75 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=6.0 KILL_LEVEL=8.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.110243 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Thanks to Jagan Teki for noting that three functions should be static and comments from uclass_clk are redundant. Signed-off-by: Xavier Drudis Ferran --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 25 +++---------------- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c index be5f79490c..2b33b6f03c 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c @@ -182,25 +182,12 @@ static struct phy_ops rockchip_usb2phy_ops = { .of_xlate = rockchip_usb2phy_of_xlate, }; -/** - * round_rate() - Adjust a rate to the exact rate a clock can provide. - * @clk: The clock to manipulate. - * @rate: Desidered clock rate in Hz. - * - * Return: rounded rate in Hz, or -ve error code. - */ -ulong rockchip_usb2phy_clk_round_rate(struct clk *clk, ulong rate) +static ulong rockchip_usb2phy_clk_round_rate(struct clk *clk, ulong rate) { return 480000000; } -/** - * enable() - Enable a clock. - * @clk: The clock to manipulate. - * - * Return: zero on success, or -ve error code. - */ -int rockchip_usb2phy_clk_enable(struct clk *clk) +static int rockchip_usb2phy_clk_enable(struct clk *clk) { struct udevice *parent = dev_get_parent(clk->dev); struct rockchip_usb2phy *priv = dev_get_priv(parent); @@ -217,13 +204,7 @@ int rockchip_usb2phy_clk_enable(struct clk *clk) return 0; } -/** - * disable() - Disable a clock. - * @clk: The clock to manipulate. - * - * Return: zero on success, or -ve error code. - */ -int rockchip_usb2phy_clk_disable(struct clk *clk) +static int rockchip_usb2phy_clk_disable(struct clk *clk) { struct udevice *parent = dev_get_parent(clk->dev); struct rockchip_usb2phy *priv = dev_get_priv(parent); -- 2.20.1