Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E748BEB64D9 for ; Tue, 27 Jun 2023 05:42:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CD659862AA; Tue, 27 Jun 2023 07:42:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=in-advantage.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=inadvantage.onmicrosoft.com header.i=@inadvantage.onmicrosoft.com header.b="clCZhQF4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C014C8469F; Tue, 27 Jun 2023 07:42:39 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2071e.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5a::71e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E800E862AA for ; Tue, 27 Jun 2023 07:42:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=in-advantage.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=colin.Foster@in-advantage.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M8L1ttUt39x4xLB76pLBdEoBHhdIaxKge1M4/zscFaV3qUtzDgX8dkzTdHIb6NMlp4nZigh4mSQ2b3PH5hRCyHu/HN2RKz6ITfIFqsN8vAGmx1lXIhRsh812boQo4Gh0Vjf/1VlkXupcuK5u/eme2+6RhguDz3xLhwlL8j7fFMBfBAD0zqwen6nSOtaa1qb5SeW45BGwCpIPonY0ANj56y/+UimE/+Dz5w/OZ1vrkH7adVqTa4xrih4HP7ksCbFKb9yysjbPJk/4kB8uj4X3+6+XjDc8WoSbWpQHeqYGmGE90YXum3RVVViZ6TuZ5WvdZsT6g71UoHPvPnFvzBlvyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ltda6zdviPaU3GbBiTK1JkvM2AGwntlNvSO0garsyp0=; b=n3XIhx+KbZD7C2weLgZfyrIuAff+8BMWRfIj3XH15wuGs4giydswqO2ZCA5ch6HNClSgLuhlIPkuX2Apj2aZdjt/C8jfOtmtlYglqE3cpKkpmU0c8SWiHWGRT7ljZgBBgvQ4p4NU81P/h4dTQbHTFKpNut3dzsQFCkKvXtpLoQrxJzIlr1eydN5hYFVHJs0W7oIvGvHUyixh8CUKaVGsGoAdDuiPE40XTRHGN54oJfW0Ms0jqM1XhEElsJqj/cC9xe58zlijtE18kzRb/5XKVAo6m578kYxrIEXTiqxGMaA1cErhyrsjz1fAruQdcBo1wZK6STr7PeDLJliASorEUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inadvantage.onmicrosoft.com; s=selector2-inadvantage-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ltda6zdviPaU3GbBiTK1JkvM2AGwntlNvSO0garsyp0=; b=clCZhQF4toWDXh1t4rqiNbi5xHyJ3ho12DLchRLhQF3WvLujH7UT0CnmrB+De/usUNhL2tO6PPBrv7FrP2TKgj7+AuFVlAtboGNLOGUpV3SOEv8aLPA6K0Xk3jhMQYaWMxl3ftpCTzR8M3diK4R9Uwd2I03Ff47dxF0scztzm+c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) by DS7PR10MB5246.namprd10.prod.outlook.com (2603:10b6:5:3aa::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Tue, 27 Jun 2023 05:42:32 +0000 Received: from MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::50f4:806b:a6be:98da]) by MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::50f4:806b:a6be:98da%4]) with mapi id 15.20.6521.023; Tue, 27 Jun 2023 05:42:31 +0000 Date: Tue, 27 Jun 2023 07:42:22 +0200 From: Colin Foster To: Michael Nazzareno Trimarchi Cc: Roger Quadros , Dario Binacchi , U-Boot-Denx Subject: Re: U-Boot OMAP GPMC ECC change Message-ID: References: <9ec2a385-a991-c3c1-4bfe-18b79793688d@kernel.org> <5e475f93-bf2c-fa28-f594-e8182e96c0e2@kernel.org> <20fbcbd5-056b-407a-c506-c29b4359d669@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: FR0P281CA0191.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ab::14) To MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2351:EE_|DS7PR10MB5246:EE_ X-MS-Office365-Filtering-Correlation-Id: 81080461-4600-480f-95f9-08db76d14cf6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OY49gG5vMngOEsUmC715SuqjwUGQtgpkLvRcHm0BnOEWCtKYsbDaiyNMlEZutiveLskNM0HnuNqYnb+KxdPTHaiyHO8jJ7iLDasI9w1IX2b/nKmwWzwkoJxz/l1PDf4O7B7CojOXGEDunYkewo+GNjZGSJQjVGAM43dkQEDHtO8m+1mM04E40u+l9KH17y8iWsd2XZWpmHuzwvzGjPQoExmjYM+0M/P7LF/UGPxhwrZT3ESb6aiOzARTxlYfj+b6e/+Xx3AJDsBC1npT5bKUTRR1/MedYYRD5VA01d94HTIUYzn0hMJgCSSvNSO4ovIhj/fWa8p03cIj2N8lGmwoIL2vfsT3pju0OGTBP3AcJvEvLrNF7agp1nslV4mwLKxgX7oTN18QQVcOvZFnLV4uU6c3P1FKmbjjDjcuZ/X6L9+e0gXC87G7rIcGqcwXE87W3Qf80L8I1cWEBR4VujD2DpSzeHznWjH7W8KJeTaXm5rDAAncFD6UGvezFaV/udh7ePy5Gv8nHNUsQaueqSWfUzho32SVe7xMUNy4EHK1ZY8mesl6QzcLxowsLCL/F6HK X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2351.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(136003)(376002)(396003)(39830400003)(366004)(451199021)(6512007)(5660300002)(66946007)(66556008)(4326008)(316002)(6916009)(66476007)(478600001)(44832011)(8676002)(8936002)(54906003)(86362001)(41300700001)(6666004)(6486002)(2906002)(9686003)(6506007)(186003)(26005)(53546011)(38100700002)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KlGaeBFkyCEnmzfakLp+NMhATssJ1uAJwncVqETNwOLfy+YoIeQaunc/dTJ2?= =?us-ascii?Q?a9nu1LO1VVKd55Y+U22KPnf0bzu2cG1pHLo08Tr5V1CSuHHoDjkeMbpnNRlV?= =?us-ascii?Q?NAT7ieVGRdRWEuwvtWyFM9XNGLbuZt4bAKzMPTa274y9bQU0CZbOWBuf2bhv?= =?us-ascii?Q?2lYxIQgLG9bvMPmoZFZkEtSVv9iHn+/s2mp14++uvTMLHYGP+vbXBNlxhAod?= =?us-ascii?Q?ltxcavuUdyyc2GFBVmCqyyybkURhEkymZ8JXnUri0O5HiFBTYUEe98aKoqDj?= =?us-ascii?Q?3Nz+yZQesGKDb8CNk3gouOs6NS1eBdbwhkhAT4iXuA1iO462HMksdWDp0mid?= =?us-ascii?Q?tpOuFAh6RoFuQm1MbGNLwvgo0ULZ8fZidLMzSldCnPTaR99SiR2ix+3G+Q99?= =?us-ascii?Q?WFfU6pKt3MKRdFU+4ie2xgTE56OrX2mOk0Do5y2ivYDu6rwTQ0K67Xw5iLZA?= =?us-ascii?Q?o7+Guw9HJnGU2owDH4UaHrHPuGvr6YZNegGMdLCjhx+iwt5xzdtih/BjFDN5?= =?us-ascii?Q?6BhYuVzv70DfEuyRwHv457UV8RoA5lD0H1t/GRIEoTaN+xuDstxPzxyO4tMQ?= =?us-ascii?Q?cBpRo/W4Rrsw90dykbokVQInNHEGis5R5FT7JrcJ/X1z+eju85LfPFro5I//?= =?us-ascii?Q?JOSMfS4P86aeF5UbhX1UCvsMRcXKj2ID20CFUeMz9GsXoBor7sRiF190AESb?= =?us-ascii?Q?G7mwg0Sw8v2w1Q2bw3+x0FBWUsjTznVPKQ9llfgiyaKE1S7KcCpSdijw/P62?= =?us-ascii?Q?u9FAVJ+CFcvPBPRVJSIzgF0weKEDPIluPLifn/aDRWoWETfvGYVseHam7O0M?= =?us-ascii?Q?j29gJq6Rth/qYHUb4KAKirFEwQzTxpJPPI2OSvC5SDvI1EzrpYpQ1wsAgzKX?= =?us-ascii?Q?BICWo3SNltwnes0nMcpAajzs/zOghqPBYOUJA7bDlC5yKTkQl/HKel8xB4If?= =?us-ascii?Q?eGkbtJZobYHF6BpJJiE5jpMnmf5TWGbP/9v12ihc30rdbn7/Xak7M6AohI+7?= =?us-ascii?Q?V07TfjLzxVD+uk8n4F6Raj2h504oX2RvOGzTD8qRlhSUSKqNNAoC2L8YX0Th?= =?us-ascii?Q?MCDv4J97hM8uFlWzocC9yDWMBC0EwX3i51NHIbWcsDUuWg5r7s5foOulBd4c?= =?us-ascii?Q?4YD3CKQSg3V6x+KLzrRxGBTzWbV6sErkAuxPJtthWj5uPmONPQMwTlG9DHp8?= =?us-ascii?Q?zXe/PdeQ1/wbqcdEfkePGrPT2JjJ0iPcb10pGkFKYVHARjLj3ecZ08h2WRdA?= =?us-ascii?Q?vUNHGhwr2CMPxLZVnnpe9FXb4FRKj8T6kIwuTzBGHYJPq0KOR4rw+rYj6Jyq?= =?us-ascii?Q?V2Va2zQjw8SJdcEUlSJ3WtNg6zzMbYtmoBo2CkPvLD0TaYvsNpF4/t++salu?= =?us-ascii?Q?zxxY+uuKCn/V7FWPLHzoa/3J6zoo/8r4SqxWJRSVRqjg/df21GIV3fEIF9Am?= =?us-ascii?Q?ktY1fXdfXfjT7NK47ftP0EFQRG9gvYqzKE/I4clidHVjCUu2yklRi9pnZyvD?= =?us-ascii?Q?PVb1Y6ufDGvL3JirmNd3zOxKgoqD2bnpiURTnsqhlQP/O/AzPsLnf/FI9yDZ?= =?us-ascii?Q?lZhJ0pYdumSnrNzMuU9EzClSGYrtABCaXVVaueWfOJSNOPZenv5wwrc61cNz?= =?us-ascii?Q?2Q=3D=3D?= X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81080461-4600-480f-95f9-08db76d14cf6 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2023 05:42:31.7475 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UP42WBzmWaxp6AFaKV/q1XigTklWgik6+YLH6n7dmMLk5Hxp1mpDH7TghSh0iQRVx1li0If3W0v2diJrmEMcL8OzsDgCmOnR9Eo1rEj6Eeg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5246 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Michael, On Mon, Jun 26, 2023 at 07:03:19AM +0200, Michael Nazzareno Trimarchi wrote: > Hi all > > Il sab 20 mag 2023, 19:28 Colin Foster ha > scritto: > > > On Fri, May 19, 2023 at 03:41:34PM +0300, Roger Quadros wrote: > > > Hi Colin, > > > > > > On 19/05/2023 02:19, Colin Foster wrote: > > > > Hi Roger, > > > > > > > >> Can you please share your spl/u-boot.cfg? > > > > > > > > Attached > > > > > > Couple of questions there > > > > > > 1) CONFIG_MTDPARTS_DEFAULT > > "mtdparts=nandflash:0x20000(xload_raw),0x180000(u-boot),0x180000(u-boot-2),0x1fce0000(main)" > > > Is this correct and matches with what kernel sees? > > > I couldn't see the NAND partition table in the Kernel Device tree patch. > > > > Yes, this is correct. I intentionally left my MTD Partitions out of the > > kernel patch, since I don't want any changes I might make to the flash > > partitions to require further patches. I'm currently at this structure > > (SPL, 2x U-Boot, and main UBI with A/B partitions and 2x U-Boot Envs) > > > > The SD Boot version of U-Boot doesn't use NAND, so it might have a stale > > partition layout that I'll need to remove / modify. > > > > > Was any end up here? I got pulled away from this before I could figure it out, but I have an idea. I suspect the ECC calculation is working as expected. It is just that now it is pre-calculating the ECC for regions that my flash writing was simply ignroing (just leaving erased). Previously the ECC would only be calculated for pages that were correctly written, so wouldn't cause any issues. I do need to verify this hypothesis, but admittedly don't know how soon that'll be. (I won't be near hardware for at least a week) > > Michael