Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3640EB64DA for ; Wed, 12 Jul 2023 16:28:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230474AbjGLQ2Z (ORCPT ); Wed, 12 Jul 2023 12:28:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232605AbjGLQ16 (ORCPT ); Wed, 12 Jul 2023 12:27:58 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 324F0E8 for ; Wed, 12 Jul 2023 09:27:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Qz+Pr3DicCPGRIg6D9Ew+k8boFpiSp9dQTXZ91Hc2GE=; b=Lmm4ugDDc76wm9DcBioIsv+62O 3P7u4nzHJ30oBt3I53GawGj0EXLNlF2zSZ5I9g1msoCYf2RhYseb8l5ZprqDoALTJwbs2OcaX1ONN 2/R5B1hj93GBCdSFKowHs4jQbu84gjR9s94IOIGezUMyVW7HB0gubtVzzIA9vEIq6XjRq2HK3w3a0 /ymcJHfeL38/Beh6UR/WAdsZolsXd6dTl+p4apa1egU4HZ4lG/zDPAyR/d5Bf6Eop2WYGw6runQ0/ ZdUXhFw3vD21jQsRMvuhIujLJFeyEbLXyoTXcs0QKIL4RolA/wcT+Cm8RizVDIWC2fHcEEujMk/2o eMtK6lww==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qJch2-000aES-3C; Wed, 12 Jul 2023 16:27:56 +0000 Date: Wed, 12 Jul 2023 09:27:56 -0700 From: Christoph Hellwig To: Qu Wenruo Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH 03/14] btrfs: raid56: allow caching P/Q stripes Message-ID: References: <04691a8119ab8612a3f3bc4b003f44dcb189be86.1688368617.git.wqu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <04691a8119ab8612a3f3bc4b003f44dcb189be86.1688368617.git.wqu@suse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Jul 03, 2023 at 03:32:27PM +0800, Qu Wenruo wrote: > @@ -82,6 +82,13 @@ struct btrfs_raid_bio { > */ > int bio_list_bytes; > > + /* > + * If this rbio is forced to use cached stripes provided by the caller. > + * > + * Used by scrub path to reduce IO. > + */ > + bool cached; You probably want to move this next to the five u8 values for better packing.