Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6F4BEB64D9 for ; Tue, 4 Jul 2023 15:15:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 44C3986093; Tue, 4 Jul 2023 17:15:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=dolcini.it Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id CAE008611C; Tue, 4 Jul 2023 17:15:12 +0200 (CEST) Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C3DA985F9A for ; Tue, 4 Jul 2023 17:15:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=dolcini.it Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=francesco@dolcini.it Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 10A1220620; Tue, 4 Jul 2023 17:15:10 +0200 (CEST) Date: Tue, 4 Jul 2023 17:15:08 +0200 From: Francesco Dolcini To: Tom Rini Cc: Fabio Estevam , Francesco Dolcini , Simon Glass , Marek Vasut , u-boot@lists.denx.de, Marcel Ziswiler , Fabio Estevam Subject: Re: v2023.07-rc5 regression: Image overlaps SPL Message-ID: References: <37cfa797-eea6-2f20-16a4-7a44a075d760@denx.de> <20230703200115.GD3931582@bill-the-cat> <20230704150906.GG3931582@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230704150906.GG3931582@bill-the-cat> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Tue, Jul 04, 2023 at 11:09:06AM -0400, Tom Rini wrote: > On Tue, Jul 04, 2023 at 11:39:59AM -0300, Fabio Estevam wrote: > > Then for the next cycle, we should plan on adding this > > fdt_increase_size() into the common fdt_status_disabled(). > > I'm a little leary of generic changes here having an unexpected size / > performance impact. The API specifically does not "just" handle this > case like it does for some others. We should update the docs around > fdt_set_node_status and fdt_status_disabled to reference the return > codes of fdt_setprop_string itself and check for anyone else that hasn't > been considering this possible failure case. Maybe we can just add a new additional small wrapper that does the fdt_increase_size() if required? This is a generic need, not something every board should implement on its own. Francesco