Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C0D1EB64DC for ; Fri, 21 Jul 2023 16:14:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X8M0rS09lSYKw2DmtBZopA+PnSH5EZmyxuo3dv6szM8=; b=ql/xrvoi32nqxj 42Dh3yNT76p39heaZY0e+8o127yrmW3kzVvGe8MsaEos958Kjg6DpKNP0DHDticySBubKUG9BYzD8 NZDF6pVwL/BRdzxnvbWnpaRCu181HL0e0LxoK3HTYWn3GXzsava34I6PNm3zkhLYWvU78xzPeOObk gqx3fpqsg/tIjFsHWv/kSG+1xPa1+LY4fd0b3jUpve85AigsXOlyAeJty17sKy7NdAC70BsaIy1CG N83mAgibmkNteLQGSa4ve77zWLVkKZ9tjDT6L3SHDwOgXD5PFOE+JfDtIeQT1qbA/MhOc+MSYllY7 Yqa2Ow0iXenTbuqiGPYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMsm7-00EY7L-1E; Fri, 21 Jul 2023 16:14:39 +0000 Received: from mga05.intel.com ([192.55.52.43]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMsm5-00EY6n-1T for linux-arm-kernel@lists.infradead.org; Fri, 21 Jul 2023 16:14:38 +0000 X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="453433813" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="453433813" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 09:14:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="815011567" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="815011567" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 21 Jul 2023 09:14:33 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qMslz-00ByRZ-2j; Fri, 21 Jul 2023 19:14:31 +0300 Date: Fri, 21 Jul 2023 19:14:31 +0300 From: Andy Shevchenko To: Andrei Coardos Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, brgl@bgdev.pl, linus.walleij@linaro.org, romain.perier@gmail.com, daniel@thingy.jp, Alexandru Ardelean Subject: Re: [PATCH] gpio: msc313: remove unnecessary call to platform_set_drvdata() Message-ID: References: <20230721131157.26640-1-aboutphysycs@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230721131157.26640-1-aboutphysycs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230721_091437_502884_536D4328 X-CRM114-Status: GOOD ( 11.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 21, 2023 at 04:11:57PM +0300, Andrei Coardos wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. > Also, the private data is defined in this driver, so there is no risk of > it being accessed outside of this driver file. Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel