Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B61DC001E0 for ; Thu, 27 Jul 2023 10:56:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A1F16B0074; Thu, 27 Jul 2023 06:56:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 750728D0002; Thu, 27 Jul 2023 06:56:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 619DE6B0078; Thu, 27 Jul 2023 06:56:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 518C06B0074 for ; Thu, 27 Jul 2023 06:56:34 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1EFD114052E for ; Thu, 27 Jul 2023 10:56:34 +0000 (UTC) X-FDA: 81057088308.03.71DD813 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf08.hostedemail.com (Postfix) with ESMTP id 3C52D16000B for ; Thu, 27 Jul 2023 10:56:31 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="Bs32wHo/"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf08.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690455392; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HBj4cGQdUfaO0gEFLKE5gfaRoYQmAgMBhZy7l0DncPw=; b=L8PtViWyUbIUvaDQDSPXIHTTYOZuSv64DJxpq+lWV/Uq80joixr449mvhqu902/EJKviCs B4ZMMSk7gHRMSnIGx+JNs3OYxi1LXihE9YLznrBz4WeI/JugEmF/hvvHPm/yljbfFds9Nl A+XAXw5izu3YKXdmQNjd2h1lr1jP/iU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="Bs32wHo/"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf08.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690455392; a=rsa-sha256; cv=none; b=VRg7PFO/MyFCkB5UtdwEdx+BbkdHVO0cLls7lb/c0L/U9JT6VVEGqryQa8g8WIGZ6AgI74 yvkeyYR/DHfAGHpdadH9V15R1HX88ertzsah8b9cIGT1Ixf/M3aqatVoxBxnm/IyARvFdq lPLFh0Vr3cobVJfhEP5p3tEwGrexuy8= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8C2D321B11; Thu, 27 Jul 2023 10:56:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1690455390; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HBj4cGQdUfaO0gEFLKE5gfaRoYQmAgMBhZy7l0DncPw=; b=Bs32wHo/vJlyXi4LNL7J8WxTQWyfU9jX5EAVkVlNnFij9rOAylREYV3bULFB6YVWfF5yVH Uu2J7XE6oZiB/7wjH7+M+qxPkxQbAx/tblKa8i+mPSuENGPIWtPIGQtJ2doe/lljq9NaMG PEaQUc3gDaAG1PX+yRT+YrFS67zjssY= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6AF7B13902; Thu, 27 Jul 2023 10:56:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Oj2MFl5NwmQwGgAAMHmgww (envelope-from ); Thu, 27 Jul 2023 10:56:30 +0000 Date: Thu, 27 Jul 2023 12:56:29 +0200 From: Michal Hocko To: Aneesh Kumar K V Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu, Oscar Salvador , David Hildenbrand , Vishal Verma Subject: Re: [PATCH v6 6/7] mm/memory_hotplug: Embed vmem_altmap details in memory block Message-ID: References: <20230727080232.667439-1-aneesh.kumar@linux.ibm.com> <20230727080232.667439-7-aneesh.kumar@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 3C52D16000B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: jpf185e5hea8kdhhds4hgenfqawdeuco X-HE-Tag: 1690455391-382070 X-HE-Meta: U2FsdGVkX1+SEbRaTHiVWmuL6FAVvmMEFH4X6VRIi7diHkv98hgCf3MYOuwLqvr+qJSLGc7/vZ5S6WC+sygNIsrWqxo6tImA6N+No6mzsDgeOcMlFzIf4n5HsuO5Kdw18oNWcE3jL7Ryc/HQ/0OBM4+fgJCAKMe9Cm1dztSUPk5Pklc7a1XN2J/GXoqygG953c9SekP1ZV3u5FIk2I7gqv4IeDX6QPTo0orUpTEGd1XULiDL6glXHIxl2eQantvD0DzW1G/PmsewSbdO4Fj+vqhiVadfC53iNuW3eI/sev/1ih6NhDAnOg1RWr62pTKwIRM2kWghZIs1XJX7gjHBMq5UoKH4yOF+23//P4QPiTyGT34AURwNn3b6gRfFy8fdBLo8I/rKk8No02hETq3QlqmK85FxFl1xSfLHJL1Qb+Soka901qJkMb4jRHBozrI+ynKV5Y3OBv516BlZ4J8BiuQ0gCmpwjxOnbWt2Sk7s45Pt1n+KOBPreUE/sYVNq5AI2ss3U3u7u+jMcnYi7ox0yfDz554ZhqjNxS07I7ajXYp9UULzimax4PHQDVLIITWMlvcn60WBXNGxDv/dGarQha+0Ms2v0KJBv1IQQfg/YVIAKwPd03sjWA+wUT2BFtebqsJGWdTPVtR8fbg1eTHiM5Rb8QuL8A573qZsphpgK0V3gVYxXOT95yDqaGayl2aPRjEQPMstwxz0lyO8uT+sCCkPWPmiEWc91Cm2dnPNOa5rMk/wvcgdhyZ9gdzoe8jVQsNWQWkOEsWG+mDnIrOvTIXf+8/tkoAYbtpPo9q+HK84a/7k+ee1Aaq0XiHSlo34m2qtZYPMIcXM3Muh2K44zH/QNX8avQakGc1D+MYOqzhtVdakk7tsacXQ2kJxji6Nw6VqihSskgtRtf43y429a61KoiR/sKqzLWcxHuHZbCk6+PnW2Bq4NK2l6F6DkcxrokUwDPK6SBWhGWU+3n jhvUNsjk J+zUqmM0mJNGiLlckDCTtgd6rTQKUhJJQ1r0c36wrtB2/p3LXy7c3B5+DUxhrqQP2nSWi7tTQC1/S2Huja138yKc4FsY0eadEHSbkSqfdbaXqxopZGkxybr2BS3or5X3kDTA03lkwTazzokUGQpjhC2LT33GJvYZjED+NRl3Ln8Qe2YkTetbzvJpbLr+/9p1Wm5OD9TgULSclRck/Jg5DHuvvcpXAyqXkI062 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 27-07-23 15:02:12, Aneesh Kumar K V wrote: > On 7/27/23 2:55 PM, Michal Hocko wrote: > > On Thu 27-07-23 13:32:31, Aneesh Kumar K.V wrote: > >> With memmap on memory, some architecture needs more details w.r.t altmap > >> such as base_pfn, end_pfn, etc to unmap vmemmap memory. Instead of > >> computing them again when we remove a memory block, embed vmem_altmap > >> details in struct memory_block if we are using memmap on memory block > >> feature. > >> > >> No functional change in this patch > >> > >> Signed-off-by: Aneesh Kumar K.V > >> --- > >> drivers/base/memory.c | 25 +++++++++++------- > >> include/linux/memory.h | 8 ++---- > >> mm/memory_hotplug.c | 58 +++++++++++++++++++++++++++--------------- > >> 3 files changed, 55 insertions(+), 36 deletions(-) > >> > >> diff --git a/drivers/base/memory.c b/drivers/base/memory.c > >> index b456ac213610..57ed61212277 100644 > >> --- a/drivers/base/memory.c > >> +++ b/drivers/base/memory.c > >> @@ -106,6 +106,7 @@ static void memory_block_release(struct device *dev) > >> { > >> struct memory_block *mem = to_memory_block(dev); > >> > >> + WARN_ON(mem->altmap); > > > > What is this supposed to catch? A comment would be handy so that we know > > what to look at should it ever trigger. > > > > I did add a comment where we clear the altmap in try_remove_memory(). I will also add > more details here. > > + * Mark altmap NULL so that we can add a debug > + * check on memblock free. > */ > > WARN_ON is an indication of memory leak because if we have mem->altmap != NULL > then the allocated altmap is not freed . It also indicate that memblock got freed > without going through the try_remove_memory(). I think it would be better to be explicit here (who should free up but hasn't). -- Michal Hocko SUSE Labs