Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12CEFEB64DD for ; Tue, 1 Aug 2023 07:53:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231891AbjHAHxM (ORCPT ); Tue, 1 Aug 2023 03:53:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229971AbjHAHxL (ORCPT ); Tue, 1 Aug 2023 03:53:11 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40E52D3 for ; Tue, 1 Aug 2023 00:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=G6zUJw5hj0HCGluUha3R6TE6nsAx6vUgtTzQzk2zJ6U=; b=dgn+f2VwKSKin5RtilLNbvMOQF YoMVxWVuD/kyS4JoMz7P8TGfvD6ZiVscUkiGHIexP3zhKDwEZrJAFzkSM4440lrivwIx0m9HvGUpc 4dFpgCy9m7Put5633+vaPdAmGFvjt1PsX8pGt3qmAD8CZyYhqV0A6+ibjtT0HGiV59ju3Nm7wD38L eAxdScDWTgyhe3Cv2f+aCUhQD4+erh2VxztWBw9ZjuV6KyMvkTP/Srg7IymMSiCg5kxLaHPQnCB/n lTMA4SomSTlGMgb2JUlsN5nkuOHtGQOIpDfCbbqTUZiReK7AZD8kOucDxqgGT2ZgNGXqTBy2VSh2W kJNYkRtA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qQkBq-000ahA-0F; Tue, 01 Aug 2023 07:53:10 +0000 Date: Tue, 1 Aug 2023 00:53:10 -0700 From: Christoph Hellwig To: Naohiro Aota Cc: linux-btrfs@vger.kernel.org, hch@infradead.org, josef@toxicpanda.com, dsterba@suse.cz Subject: Re: [PATCH v2 01/10] btrfs: introduce struct to consolidate extent buffer write context Message-ID: References: <1cc8f3a21680d196751171f09ddb77b9c14a5b9a.1690823282.git.naohiro.aota@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1cc8f3a21680d196751171f09ddb77b9c14a5b9a.1690823282.git.naohiro.aota@wdc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org > + struct btrfs_eb_write_context ctx = { > + .wbc = wbc, > + .eb = NULL, You can drop the eb initilization here, as all not named fiels are implicitly zeroed. With that: Reviewed-by: Christoph Hellwig