Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 241F18F69 for ; Tue, 8 Aug 2023 19:59:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8D7FC433C8; Tue, 8 Aug 2023 19:59:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691524755; bh=vaL2GmK6E30etgPK/7amdzCna9Tu7rMpzE4Hc5iSZ1Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eP3OhvsFV740uKM4wAelsA49oWXmvK9xYJHKORXwcTkDrSeQp+Xdqc/mvhWuQMbZg pu3WzPRtCxrVoaon4argOZWH/7Gf3fPWD7R1e9/pGriWEboaYGN7O87Hoc1zt5Gp42 AawQxcbbq9OdbOM/KhVTxNnezvS1Yvj4jDQG5pHdiukdD6ciNEfVwRLAz0TtC/Eh+L 6aChhUkEzYBezywSBFJikE0og6LXAYWNCZm/4DOCxbbLK8ZblLQcJHp7FNYjIJb1EB Ijsei8Gve7vDojv3odcpuWgr1J7hDyOWCJranWmKVDFGKtyoh1f8SmhsAXFWptXGt1 vxn8Hd0urihmA== Date: Tue, 8 Aug 2023 21:59:10 +0200 From: Simon Horman To: Furong Xu <0x1207@gmail.com> Cc: "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , Simon Horman , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com Subject: Re: [PATCH net-next v2 1/1] net: stmmac: xgmac: RX queue routing configuration Message-ID: References: <20230808021906.1120889-1-0x1207@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230808021906.1120889-1-0x1207@gmail.com> On Tue, Aug 08, 2023 at 10:19:06AM +0800, Furong Xu wrote: > Commit abe80fdc6ee6 ("net: stmmac: RX queue routing configuration") > introduced RX queue routing to DWMAC4 core. > This patch extend the support to XGMAC2 core. > > Signed-off-by: Furong Xu <0x1207@gmail.com> > --- > Changes in v2: > - Convert the shift ops to FIELD_PREP Thanks! FWIIW, I think if the code moved to using FIELD_PREP then probably the _SHIFT defined can be cropped. Reviewed-by: Simon Horman