Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7501823D3 for ; Sat, 12 Aug 2023 17:43:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D66DC433C8; Sat, 12 Aug 2023 17:43:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691862184; bh=ebop/vhKG+d6ioZES9vEyyolUgCe+T6JMuW233egLIE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JzPZCT2qbpEAkWJPc6drUu/evkBUoBXEM30b60pUouZMOb1kPzyU1jtrCIfBxtMf/ WLIPbX3NN5cCPFv0So8QLDa88E0mcxrXqehqAoJDpBCDaIbVT8Nys5lZLOMKgLhZbx XcHEmXb+NBEXauVnmQVItxoH9F6uzlqOijb3bnbZN775yfB398Hbw7MkOghPJu8hrA rvYUJXwsXzjlxpiBKVp+sl1VZB0BMBng7oTKAa98JBBYlOwG1JHWwe0nqPLixZ2L3y GVcFaUAM/6PC0ZxoXNhhKABMi1O4pnexxqm7msHHLw1qNPn8KkD+7X2zOITJrRJx9p G35go0u8CFCMg== Date: Sat, 12 Aug 2023 19:43:00 +0200 From: Simon Horman To: Michal Schmidt Cc: netdev@vger.kernel.org, Veerasenareddy Burru , Sathesh Edara , "David S. Miller" , Abhijit Ayarekar , Satananda Burla , Vimlesh Kumar Subject: Re: [PATCH net 2/4] octeon_ep: cancel tx_timeout_task later in remove sequence Message-ID: References: <20230810150114.107765-1-mschmidt@redhat.com> <20230810150114.107765-3-mschmidt@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Aug 11, 2023 at 05:58:44PM +0200, Michal Schmidt wrote: > On Thu, Aug 10, 2023 at 5:48 PM Simon Horman wrote: > > > > On Thu, Aug 10, 2023 at 05:01:12PM +0200, Michal Schmidt wrote: > > > tx_timeout_task is canceled too early when removing the driver. Nothing > > > > nit: canceled -> cancelled > > > > also elsewhere in this patchset > > > > ./checkpatch.pl --codespell is your friend here > > > > ... > > Hi Simon, > thank you for the review. > > I think both spellings are valid. > https://www.grammarly.com/blog/canceled-vs-cancelled/ Thanks, I did not know that. > Do you want me to resend the patchset for this? No, not in light of your previous point. -- pw-bot: under-review