Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BC63C6FA8F for ; Tue, 29 Aug 2023 10:04:23 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 467C93CC0ED for ; Tue, 29 Aug 2023 12:04:21 +0200 (CEST) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [IPv6:2001:4b78:1:20::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 3730F3CA99A for ; Tue, 29 Aug 2023 12:04:09 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id CB088600EB2 for ; Tue, 29 Aug 2023 12:04:08 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DD48F1F45F; Tue, 29 Aug 2023 10:04:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1693303447; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XuHEqfDzZogzv2q2esKNKIYoVI1IE8SplxGzd3ld7h0=; b=df2tVTEdGYkZKzaWgm9PikyTVROINy4MXPsDWSL57NyerTB+jG1e8TBqlchpmgJDu/vy2M 4IwkCOu++PjjnolCumfZOuu5I/E9k9WdBDK7cvQShJtqj66ImRAU/95Sm+aGG6yIjbmVQF 5q5yuym7lfHfK7O/F1mLLrSbgY2UfvY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1693303447; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XuHEqfDzZogzv2q2esKNKIYoVI1IE8SplxGzd3ld7h0=; b=tUvYJPBREjsKXb+idFvJinDqvZ9USDJ+3/L1qe6zcID1OCgTAxacpGd5GnjNoeJFVnc4IX KzMLK9hY7K8Jt2Dg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 62B8E138E2; Tue, 29 Aug 2023 10:04:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Bu/yC5fC7WSRbQAAMHmgww (envelope-from ); Tue, 29 Aug 2023 10:04:07 +0000 Date: Tue, 29 Aug 2023 12:03:46 +0200 From: Cyril Hrubis To: Avinesh Kumar Message-ID: References: <20230818112023.18159-1-akumar@suse.de> <20230818112023.18159-4-akumar@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230818112023.18159-4-akumar@suse.de> X-Virus-Scanned: clamav-milter 1.0.1 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 4/4] syscalls/mmap04: Rewrite the test using new LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! This is nearly identical to the mmap02.c and the same comments apply here. Also the test does not check the PROT_EXEC part at all. If we wanted to properly test PROT_EXEC we would have to copy a function code to the file first then execute it, something that mprotect04 does, but since that flag is already tested in mprotect04 it does not make that much sense to have it here as well. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp