Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC36ECD54A9 for ; Tue, 19 Sep 2023 09:00:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229690AbjISJAn (ORCPT ); Tue, 19 Sep 2023 05:00:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230168AbjISJAm (ORCPT ); Tue, 19 Sep 2023 05:00:42 -0400 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 756AC116 for ; Tue, 19 Sep 2023 02:00:36 -0700 (PDT) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 498211C0006; Tue, 19 Sep 2023 11:00:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1695114035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4hBjYqnHioxAljadUYvBWmhxzxhBbJWSHM8kDf6Txds=; b=HkQKU9gih158Pz/vB5sQeLEWDO+oZaGvXJ8rJAN7ZILi9YpOge6577Z0ok69LfmWMhExbz BVXOyUsHTI2DeCrPrXiKufXoyF22qS5p6Mf6/ZpbOjnKz1o/lv04Lx9/sw9Cz9Mp2PGE+d C9pYPSH415UkDjT9lZOAFwb2SSJzvaI= Date: Tue, 19 Sep 2023 11:00:34 +0200 From: Pavel Machek To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Lee Jones , linux-leds@vger.kernel.org Subject: Re: [PATCH] leds: Drop BUG_ON check for LED_COLOR_ID_MULTI Message-ID: References: <20230918140724.18634-1-kabel@kernel.org> <20230919104207.7bf1b237@dellmb> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="u1xZ2FvVBerexcPE" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org --u1xZ2FvVBerexcPE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > Greg tells me to pester LED maintainers to get this into Linus' tree > > soon, so that we can avoid stable incosistencies (see > > https://lore.kernel.org/stable/2023091901-vessel-giggling-55ee@gregkh/). > >=20 > > Sorry about the inconvenience, this would not happen if this was not > > sent into stable in the first place, which is my fault, since I added > > the Fixes tag. >=20 > Actually, no, it is not your fault. It was pretty clear your patch is > not "fixing serious bug" so it should not have gone into stable in the > first place. >=20 > For mainline, should we perhaps keep the BUG_ON and fix the affected > driver, instead? Aha, rereading the discussion.. yes, we want to drop the BUG_ON. Sorry for the noise. Best regards, Pavel --=20 People of Russia, stop Putin before his war on Ukraine escalates. --u1xZ2FvVBerexcPE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZQljMgAKCRAw5/Bqldv6 8o/KAJ9HDZWX4wd2L3KM97jZWhDyR+2pUwCggyoVPbA/aHPfEVnS7zJ94/1/Vs0= =VIhI -----END PGP SIGNATURE----- --u1xZ2FvVBerexcPE--