Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4277CE7C4FF for ; Thu, 5 Oct 2023 09:11:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FeDAub++y5/jy0+9an/1drQ/9j1yHlgCLwPLc4UjwlU=; b=USuthmUdYeuJ5D 9axdzVGQk3tsNJMJzPFh8bCY5YV7X/jnXWAE76T4vKjd9oC+akhwTCISyNQkFSpc7KYxzSbSvDCJw Ac1otKGWMo+pTW/PXespxKj/Q5MDEZV2o55z0w69d1IrD/PVRindx7WI9MdmI7B4CJ7UXLhylHBFa tgYfunsUJF3CX9xRFHD0+T65Wc9F2SUSjBaUprwzywxQy04aL7ZUKS+tZWCj/iLBhFGXsrtQ7iJ7w a1B4LbdCPhNAT9ZgYqTM9jNmeRPJRBxrg56JRZFpcJj8EcIRlaTyILHdZRL3sb7rj9uyMuVo+vhRY nZ/1OUDLHKKdTea599TQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qoKNI-001jdv-1x; Thu, 05 Oct 2023 09:10:28 +0000 Received: from mgamail.intel.com ([134.134.136.65]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qoKNF-001jdR-0i; Thu, 05 Oct 2023 09:10:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696497025; x=1728033025; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=R/dDDcKZGfPfb/XVYbaUQl8M19BfdQjLxL+jfR/Q0Vs=; b=E1vUUU3ps1o22hcy38z7YjbM/qAB+bKFjsvGGqV82t/jQe4RVLjygFCg Z/6t7pg0NCR3uHW+WtDxIigsBGNmSiRMYIH26ErlSkndEcvR2J9ShHXXk o6NXxZc5yQ4Dcw27UrRNyw0UVrjbGAgs4y1MklfHtgKyW9fqL2B6sQ2ab pS9xGXijB6V/5HGqAt59PbbR/f3mQwcm5KslJgn9vxowv7yvb7mTrFpUs Kzu6zHBGikwoLmzH0e/pdSJnHlYvot29LIikiqjm2I7T56VXIZrvhDyZc 2vZ5s88A2WzRAOdXmwDoU5g4oxFbMN4zZHfSTy5Ey4K/ehR0HTnml/z6u w==; X-IronPort-AV: E=McAfee;i="6600,9927,10853"; a="387323342" X-IronPort-AV: E=Sophos;i="6.03,202,1694761200"; d="scan'208";a="387323342" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2023 02:10:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10853"; a="701593202" X-IronPort-AV: E=Sophos;i="6.03,202,1694761200"; d="scan'208";a="701593202" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2023 02:10:18 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC1) (envelope-from ) id 1qoKN4-00000002z21-44P4; Thu, 05 Oct 2023 12:10:14 +0300 Date: Thu, 5 Oct 2023 12:10:14 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Mark Brown , Florian Fainelli , Linus Walleij , Ray Jui , Scott Branden , Broadcom internal kernel review list , linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski , Hans de Goede Subject: Re: [PATCH] spi: bcm2835: add a sentinel at the end of the lookup array Message-ID: References: <20231004183906.97845-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231004183906.97845-1-brgl@bgdev.pl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231005_021025_439170_E1A98114 X-CRM114-Status: GOOD ( 10.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 04, 2023 at 08:39:06PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > GPIOLIB expects the array of lookup entries to be terminated with an > empty member. We need to increase the size of the variable length array > in the lookup table by 1. Right and seems we (used to?) have the same mistake spread over the kernel. Perhaps a helper at some point? Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel