Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3DF419459; Wed, 18 Oct 2023 10:38:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ThfqWDvX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697625513; x=1729161513; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qLHbWCmacxKJ8ooul8n81Sg2BO9OMG+tTZkTP0mZUGc=; b=ThfqWDvXzRAAT36b7awQiDhx9YU/ATwPfB30dut883ZoIsC8x9ySAR8P tdCT2p+YIH0peGEg9xZxVh1VxTO5OXlimEWCS+KUIzhxUsJKZQOMM571+ P7CnT76mrkAJr9ZvtisQBnzqPH6iSgl3soeMJ9ypHWlEz1CVBoLqsy/6k Ha9RgBYqi6HxtH8iTnDr+HaX72dcNPqMEYLgG6YVWOrEfsWZ1THWZfUbe Cubu4oo2egsihtsS33l27WVRQeYnFv4pZQ9Ts7Ft9zdiX4Z+QN4GZ+yA2 M7SJNlrs9LnOy+30LnqDyMzPu8RgTLwm0k3cbD/dIKh4WurOaSVZMtPxT Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="472211348" X-IronPort-AV: E=Sophos;i="6.03,234,1694761200"; d="scan'208";a="472211348" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2023 03:38:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="785882037" X-IronPort-AV: E=Sophos;i="6.03,234,1694761200"; d="scan'208";a="785882037" Received: from nurfahan-mobl3.gar.corp.intel.com (HELO intel.com) ([10.213.159.217]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2023 03:38:26 -0700 Date: Wed, 18 Oct 2023 12:38:18 +0200 From: Andi Shyti To: Julia Lawall Cc: kenechukwu maduechesi , outreachy@lists.linux.dev, shreeya.patel23498@gmail.com, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rts5208: Replace delay function. Message-ID: References: <20231018004300.GA3189@ubuntu> <7bc719c4-459f-3d8-7ed-b1e1adf158@inria.fr> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7bc719c4-459f-3d8-7ed-b1e1adf158@inria.fr> Hi Julia, > > Replace udelay() with usleep_range() for more precise delay handling. > > > > Reported by checkpatch: > > > > CHECK: usleep_range is preferred over udelay > > This message is typically not a good candidate for outreachy patches, > because you need access to the device to be sure that any change is > correct. I actually don't really mind this patch... I would exchange these udelay() with almost anything, they look to me placed a bit random anyway (without going too much in detail). But in general, for this project, I think you are right and it's a good idea not to blindly change delay and sleeping functions without really knowing what you are doing. Andi