Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD87C38BDF for ; Mon, 9 Oct 2023 17:39:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Mmlm+Ewp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12892C433C7; Mon, 9 Oct 2023 17:39:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696873168; bh=0dEay+sldvn2MMQf3MJ+a6pHpjWE/yf7vOI+fennvhI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mmlm+EwpJvlVz45Nw4BljP1YmP5uV+A7b91duFWr7/7Uvg0rijruCNEWxiv3hFGwy lSCWfSwIB81fmupATlIMfvlGP5fpsAXgGivp9Jyh0EbQpLD0RttFIxlbizJEYcbA7l cqjbgUaih9RX2+mhKMl4R/B7GAnQn5cwadBMo5RqQbqXCZkHwb6MNtdNH/kvODJu4l wy5kFxeVp8fewrDEZze4BvRnBLsPeAHMBMcn/D+nR5MTnZQ0S/L5FPY6ylxLZmdXJv b4kTYxfqPtq1c2nihhHEdVaufPSpVVxMQTCzJDrgiffj4ybtDTxFa6fd6eYOHmx4eL G0c0QeutReCZA== Date: Mon, 9 Oct 2023 13:39:26 -0400 From: Sasha Levin To: Takashi Iwai Cc: Greg Kroah-Hartman , stable@vger.kernel.org, patches@lists.linux.dev, Shenghao Ding Subject: Re: [PATCH 6.5 001/163] ALSA: hda/tas2781: Add tas2781 HDA driver Message-ID: References: <20231009130124.021290599@linuxfoundation.org> <20231009130124.064374662@linuxfoundation.org> <875y3gsznc.wl-tiwai@suse.de> <87pm1nswbx.wl-tiwai@suse.de> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <87pm1nswbx.wl-tiwai@suse.de> On Mon, Oct 09, 2023 at 04:29:38PM +0200, Takashi Iwai wrote: >On Mon, 09 Oct 2023 16:25:13 +0200, >Sasha Levin wrote: >> >> On Mon, Oct 09, 2023 at 03:17:59PM +0200, Takashi Iwai wrote: >> > On Mon, 09 Oct 2023 14:59:25 +0200, >> > Greg Kroah-Hartman wrote: >> >> >> >> 6.5-stable review patch. If anyone has any objections, please let me know. >> >> >> >> ------------------ >> >> >> >> From: Shenghao Ding >> >> >> >> [ Upstream commit 3babae915f4c15d76a5134e55806a1c1588e2865 ] >> >> >> >> Integrate tas2781 configs for Lenovo Laptops. All of the tas2781s in the >> >> laptop will be aggregated as one audio device. The code support realtek >> >> as the primary codec. Rename "struct cs35l41_dev_name" to >> >> "struct scodec_dev_name" for all other side codecs instead of the certain >> >> one. >> >> >> >> Signed-off-by: Shenghao Ding >> >> Link: https://lore.kernel.org/r/20230818085836.1442-1-shenghao-ding@ti.com >> >> Signed-off-by: Takashi Iwai >> >> Stable-dep-of: 41b07476da38 ("ALSA: hda/realtek - ALC287 Realtek I2S speaker platform support") >> >> Signed-off-by: Sasha Levin >> > >> > This makes little sense without the backport of commit >> > 5be27f1e3ec9 ("ALSA: hda/tas2781: Add tas2781 HDA driver"). >> > Confusingly, the patch subject is very same as this commit... >> >> This is a tricky one: 3babae915f4 really doesn't add a new driver but >> rather just refactors some of the quirk handling which is needed for >> later patches to apply. It's the following 5be27f1e3ec9 which actually >> adds the driver (which we don't need here). >> >> We don't actually want to bring in a new driver, so 5be27f1e3ec9 is >> unnecessary. > >If we don't want the backport of 5be27f1e3ec9, this commit >(3babae915f4c) and other relevant ones must be dropped, too. Sure, I've dropped: 3babae915f4c ("ALSA: hda/tas2781: Add tas2781 HDA driver") 93dc18e11b1a ("ALSA: hda/realtek: Add quirk for HP Victus 16-d1xxx to enable mute LED") c99c26b16c15 ("ALSA: hda/realtek: Add quirk for mute LEDs on HP ENVY x360 15-eu0xxx") e43252db7e20 ("ALSA: hda/realtek - ALC287 I2S speaker platform support") 41b07476da38 ("ALSA: hda/realtek - ALC287 Realtek I2S speaker platform support") -- Thanks, Sasha