Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31A96881F for ; Fri, 27 Oct 2023 06:08:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="uq0nSJFY" Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D24381B2; Thu, 26 Oct 2023 23:08:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TfMZT5btLnP/blSIX4mPCJ5hujeRMgTDsbWBStTgLz0=; b=uq0nSJFYJ74IVlufASmj0nj/Ib GhKIBoqSEamgDuM89JX6ikt5ORGXoBHqTVd0qlh9yXO9GJ2wk1q1CcY90leT7DdJEPK3JJUycWdNT AbkL7dJVrXTabcEgVt6iU2S86gGeE4Gg/C3y8V+6lJyFQYxFBcMwMETCj3vx0ULxg+2bcjbJ3aN+s zCIabHP4VixyzPsQdROvBNgj1ljRaNhQDxiCa1iypSx4JEUcQEsnIMOEFN7CsrsbXbevAIqlJH3Z1 qOupSoLgeIDoO9IA1cZl/QLjrn2cHoEsyN0yKut8EQHcAhLPSH8JY08k8HSJCtag549gu1GW3mFlw 80e2bjIg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qwG0x-00FeWx-1y; Fri, 27 Oct 2023 06:08:11 +0000 Date: Thu, 26 Oct 2023 23:08:11 -0700 From: Christoph Hellwig To: Amir Goldstein Cc: Christoph Hellwig , Jan Kara , Christian Brauner , Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 0/3] fanotify support for btrfs sub-volumes Message-ID: References: <20231026155224.129326-1-amir73il@gmail.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Fri, Oct 27, 2023 at 09:03:43AM +0300, Amir Goldstein wrote: > With all due respect, your NACK is uncalled for. It abosolute is not. We must not spread the broken btrfs behavior. > The "details" that fanotify reports and has reported since circa v5.1 > are the same details available to any unprivileged user via calls > to statfs(2) and name_to_handle_at(2). Yes, and that's very broken. btrfs sneaked this in and we need to fix it. Again: Extra-hard-Nacked-by: Christoph Hellwig and I'm a little sad that you're even arguing for sneaking such broken thing in.