Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C932C4167D for ; Fri, 10 Nov 2023 18:29:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9839F8D00F6; Fri, 10 Nov 2023 13:29:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9346E8D0005; Fri, 10 Nov 2023 13:29:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 825068D00F6; Fri, 10 Nov 2023 13:29:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 72FBC8D0005 for ; Fri, 10 Nov 2023 13:29:49 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4ADDFB5773 for ; Fri, 10 Nov 2023 18:29:49 +0000 (UTC) X-FDA: 81442883298.05.CD2C888 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 927B780012 for ; Fri, 10 Nov 2023 18:29:47 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CmXw2fQN; dmarc=none; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699640987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sETFuFqSJGaVbgEWP5OyduOIoGx5CUEWS4/wqpSOq54=; b=XVaDRF8iX1jPsaIoCceoVex+SkvoL64tyFmUKlRY9NC8DKT3V9y4DiNDPau5ACwtEoylqP QUiErxAbEwcrqHK/gxCTx8z8gVCtL8BMBRLQrF0GrlOHVi3w6vRekRZsKJ4GeXGLGWvC3b bUpMq5FmEPpwCeoYJJiXsUgz/NaUNrQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CmXw2fQN; dmarc=none; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699640987; a=rsa-sha256; cv=none; b=n0ureP3FImlLeTHf6UV9HeqrtjvU6DUgHINkQZBCl5/7eVwX46O2doze0MnE6qEn5b3wjz CvyBLaGJQRXoJFVM1c/Mt/EC6uEVsepBgvv4FdHB1JRRIYXNGVLjcVIIw5IaHceQghKE1D Ev/gBYw5Ux1HF4BFkgfX/C+TaqSLPUM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sETFuFqSJGaVbgEWP5OyduOIoGx5CUEWS4/wqpSOq54=; b=CmXw2fQN5Ge3CBTGk9+fHqp0II LzZta3QGOFDQQW/PB6dn/7IHGfAe6k4yIhUUp90cat9UqHDx4hosFan46felTGtLdxY4QC+eRl0+L +X6qmY2l5XzVML4o6dP8mv7CsKxv4oK8q/gfeAD06Ej9qsPXza8TaaxJqN8bc7bfe1U3d6rLHyO/9 ExjM+LME3B1J30ZCGhKYozS5zT/BTinnBntTOrOz44WTtYtF7Q86biEz7tIogOcMWzAI4skF+wsI2 bb3LG3vpKDxDoZZnZoySBnZt/Ts3e7O/5XrwynFthd/2aDnPW+69YOdjU55QKo1HEup3d490diNiP 83MWtomA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1r1WG1-00Ew5q-Jg; Fri, 10 Nov 2023 18:29:29 +0000 Date: Fri, 10 Nov 2023 18:29:29 +0000 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Hildenbrand , Gregory Price Subject: Re: [PATCH v2 5/7] mm: task_mmu: use a folio in smaps_account() Message-ID: References: <20231110033324.2455523-1-wangkefeng.wang@huawei.com> <20231110033324.2455523-6-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231110033324.2455523-6-wangkefeng.wang@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 927B780012 X-Stat-Signature: wyq1zp5qbp9azn5ia3qegerye3pgsd7c X-HE-Tag: 1699640987-804909 X-HE-Meta: U2FsdGVkX18c6veQUGlgjGpS7vnfaI1tgTh2Jxw8giPhu35S78GGxyr9SLBTuvzYicmHRSdY6BIdmlMI0FKOWQYLvjEfSBKYKPjOWR2GdQAjtMk853bK+ttCuDOdqPxmhtYGXVLJZvSIadC7C+Zch3q7XSKXd535jv/ims41EzwcICVaYnhgq1QEG8yG5wT4G84Br4R2bbLY6eNm3N6RPk43GmsLoppIsej4nerw+pH487agSiSqVgWc2m3md70KdfOLseqRYzWxOI9gKKd1msoDSxH7fH/+oxKhWlRjIB9ZfvXYvSVftwM3z/XgtCAmW+6ZlFzoUklLZ1IrRH/LhM2ey9uRMdOhnoeZ6t44YLf0t3DzMeMltCBV9w+QJbkrrumSeap8pHLX71ddt4vaZVn38alA8Vr/23Tj9abf9bzH+oG87TdH3ROAH9DgbuF4Ap4tYTfnFGfk4lX9gXoHLRquDZ2MBnxXjXuzDZVVeqz92qMOzz54qs/uf5MFn41cl95miZT/XrUKqrxLxYKwsGikLL1LCSk3LMYmTLOnoQWMR4IKxo9rHPUgfc3Uq/2jtYy8SYo1t+Gc8w+dJJ44JGoCWAkZJUvCyRoFtqsJEJR34N762Xe5P5tXgVAvM7h3ZZp3Oax5zh2r2vC5aFZq3ofPzYX5pM66jVB6g4RVLOBMwDSYzaK8qjZDtOlX6V4mqlgoWSQIvOAFfmvbUVkC6uFMFoLTG6h1YOEDR5nmgCVHTKpc7oD7qwbFpgk1qQH1Qe/hYaNo6BNUJG/f3p60DbpwbrfHQBZG/KJsvf5wEiFBhK4XaHZoh3UX1vVeQC8ygi8SJg5MtSTyqbyJ+lkgGE7jNbYHk5X741s8ezr82Ws/h//2ew3d8WmCRohIdeEgnqi63hIKxnL0JUgmSvs4igz6tugblSugPfUWoO5UyAvpJpCNVqfVA6XxgPQpjeVqaNA7HCj/d2xr5l0Vlbx PVbrw7hq osiB8H5YQpInXPkxOKgdVK0nuEG3ICpOfdpUY+CesW30vpiqZ1bZ5moEyKyCrk5BE4FOCUABthg/WaEqZjuE3uJMnVBsUfZQNqNsTDkAtNF0kVrY6g93zZdWxGUfBwjiu/5SDH/QUfhnCiApmF87/YmBGfIX9ex1LJgYvcW19SeFIZQbF2BBVtTpl/9Dc5OnyoSob5kw2vqVG4jg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 10, 2023 at 11:33:22AM +0800, Kefeng Wang wrote: > Replace seven implicit calls to compound_head() with one page_folio(). You're so focused on trying to accomplish your goal (killing off the page_idle and page_young functions) that you're doing a poor job thinkig about the conversions you're doing along the way. > +++ b/fs/proc/task_mmu.c > @@ -445,23 +445,25 @@ static void smaps_account(struct mem_size_stats *mss, struct page *page, > { > int i, nr = compound ? compound_nr(page) : 1; > unsigned long size = nr * PAGE_SIZE; > + struct folio *folio = page_folio(page); Stop right here. The use of compound_nr() should give you pause. After looking at how smaps_account() is used, it seems to me that the two callers should each pass in PAGE_SIZE or PMD_SIZE instead of doing this calculation. More generally, step back from this series. Do a good job of transforming fs/proc/task_mmu.c to use folios. Once you've done that, you can approach the young/idle work again.