Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50A7BD281 for ; Fri, 15 Dec 2023 05:29:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="z+c7Su/y" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CtQY7KcTCGUbqzxXM2TcGqfofhXPlN3NkzbGgokG5XI=; b=z+c7Su/y35aW7BVvydk4qKg0N6 fpWjylJIiX85R7eB8p5OD1KSAX/v2LKoE1HdHs+TMwdbl13OdrxWcJ9Zh5QlHfhVVEE+CJZ8+/tFm wBj9PS92GbJnHXi/asdNcFVPzzoA57eh79tuDWRAhgCYAw+lVbWLp/qn8WY6EKDY+bd8Y8gdFpoaE vkS74aSqnIwb4dGyNVSYiK5Q17mSVJihefbAgBEQmGoW/N5b4Je90wK5WQenpzdvZ+ge9juXzEu85 kGMjIWs2vwHakfJNXg2LcDcCa8CBHv45tiObQLJdECglUjYSgJ3NmgN5M1Z8GNjJserVTLOBbkpAE eSPXLQkA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rE0lf-0024GB-35; Fri, 15 Dec 2023 05:29:47 +0000 Date: Thu, 14 Dec 2023 21:29:47 -0800 From: Christoph Hellwig To: David Vernet Cc: Alexei Starovoitov , Dave Thaler , bpf@ietf.org, bpf , Jakub Kicinski , Christoph Hellwig Subject: Re: [Bpf] BPF ISA conformance groups Message-ID: References: <20231207215152.GA168514@maniforge> <20231212214532.GB1222@maniforge> <157b01da2d46$b7453e20$25cfba60$@gmail.com> <20231212233555.GA53579@maniforge> <20231213185603.GA1968@maniforge> <20231214174437.GA2853@maniforge> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231214174437.GA2853@maniforge> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Thu, Dec 14, 2023 at 11:44:37AM -0600, David Vernet wrote: > > > Why else would they be asking for a standard if not to > > > have some guidelines of what to implement? > > > > Excellent question. I don't know why nvme folks need a standard. > > Lack of standard didn't stop netronome. > > Christoph? Any chance you can shed some light here? netronome is a single vendor implementation. You write for their device and the standard is what they accept. NVMe is an open, multi-vendor standard. You need to be able to write your code against the spec and run it on all devices (that implement the required features). NVMe also needs another open standard as the reference as it just can't point to a void. > I agree that there's value in instructions having specific meaning and > encodings, but my worry is that (for device offload) the value would be > minimized quite a bit if a developer writing a BPF offload program > doesn't also have some knowledge or guarantee of what instructions > vendors have actually implemented. Absolutely. > If we were to do away with conformance groups, then I as a BPF user > would have the guarantee: "Any hw device which happens to implement the > instructions in my program will behave in a predictable way". If that > user doesn't know what instructions it can count on being actually > available in devices, then they're going to end up just implementing the > program for a single device anyways. At that point, how useful was it > really to standardize on the semantics of the instructions? That user > just as soon could have read the specifications for the device and > implemented the prog according to the semantics that the vendor decided > were most appropriate for them. We need the concept in the spec just to allow future extensability.