Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2836A253B41 for ; Tue, 15 Apr 2025 23:38:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744760324; cv=none; b=bvy9Ilm9QtlGGcwHrIuWVe0Tn/AupEEdnAwhFGkRqbUFnhZuta3txHZ9Qjzuf54s4DFKOz1/yN5KfChy1c94UDvoMXstRKnSqpj7giSxojFY/F9Es1okW+ACpV6qbOjeYYXUDgX5O4wHIEZpd7QrZsKGKWNsZsj28Un/Ivs7g1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744760324; c=relaxed/simple; bh=R+EQXz9EaaJ5nmZF1v0kHrTrolPYealYIAsKGPLU6Q4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Zz8YfE+pi9ytgyDTa+bzcaD5mqwQLESkGOlqW/Gc9d2uJ0qL0botnWZQ2zdk3UNPKi4HSBKkRQQO7TvW3lWQd4cnKf9jr8uWSENg3nGiuleZUodUoYT87KPYfVL1H+11hiQSClGY6dRFaLzHoYISTSw4GWPEAGwlGjZjaTl3LV8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com; spf=pass smtp.mailfrom=fromorbit.com; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b=sGwHcE/R; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b="sGwHcE/R" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7399a2dc13fso8153198b3a.2 for ; Tue, 15 Apr 2025 16:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1744760320; x=1745365120; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EpM4EYhinbZUnOqyrMXMayNGRnxZN7y4BbC9ozLOlx8=; b=sGwHcE/RQFxEif8PxH4a0Hq8nU6CUS4KKAFoWVz3gir2IPji8XEXJXlnMK5KYDjXF1 k/NF0pyd7XOFgMLxF7nVhXG0eCaNyagvmf0TVnwf313H8XKuFEVVBhZ7k3F5wKtJCz3y AhWo+RJKbykig/TbxfT+lkmUaSWGVrGsUzH3r3uy2EelZcVKGbf8yHUU5g4pv/THzZP2 0oaGmBQhOdFJ4Xe6vPlt4451bjk3vdk2NpKLwsMPG9dF2a/Vw1nvW0Nsmdg3cXj6MnHq H5rI1vx1lvVxF/BypjAD/hkA7sL9G0i/ryp8EzuYa1f+DvTCLWtPbGj3UoCqNwhdqBWf Azlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744760320; x=1745365120; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EpM4EYhinbZUnOqyrMXMayNGRnxZN7y4BbC9ozLOlx8=; b=PLjZpfbGQPQSULBxaZs2GNcSaOTRWuWnVAYBJFJQ/8KYM/N12ET573je8H+A3hh4yK My85rYB8rV6dfhZ7XQA1RtMTIGSGniHFNPlboUAWqWVSNUE6cOJwMp3ZrU0VYJPD2iqW X/jb39Y+4cGMlymVHI1LZsYlKl7bm2RUmPP2bMVYr5VqlsuzqOHs0LTQrc7DEHgLClfB Z2EkPJ3BWbv7yNb58+75ptcbO2dsZXT7GXmJhCPD+w53xoN2xvL3FqPIOznIrDWcn+x6 hDHBJV330IsnEe24YtER44pc9PCbo0UEg1IeSeeoQU7x+EWTWYmtSjST6IJVBQnlJqOK dBsw== X-Forwarded-Encrypted: i=1; AJvYcCVIP+jvkbIFwQSmwFYyG951QM8q2gTIdPwTt/R969QElEUpPfUecN2oVWxFh6ocRTiUsW4DZwaA@vger.kernel.org X-Gm-Message-State: AOJu0YxKfT8dyS15Wvmtmr63hQDNI+c6CdTUtOkEnXNY5GD+Q4PSsi97 sVTgkEasjuCYj+5CaBxz8LZfqn1JrwSYbAoh9ajd2pNwIfFedCOiSJFwbu7zBrY= X-Gm-Gg: ASbGncvTRtOBu37EDlOXR9vWThimZoZ/IIP7grfuYO0d3TE5UYdD7TpGoIvbq3lmtZE tKbcIcI0wUGrLk/2+HM6FpfPbFZU7ARnAvCl7O0DzKMX5NkY0L2U2WcFMCrnhXXrfEcfKIjgPrP tzOVVnv3PEoTW3Ka/Metvlo7muDwlWB+nRQ7SXfjlnXxaKu2K5rHCHr/WaNHt1nu7KBMDwxPymO cxT0sFpGJDhho3ek+ZCqFb5TLLHBo/gL2gUmTUdpUtCUq7GOUpMy6Ev4sXuq+sQAHhDhguA59nD HPO09v2BGy61fUxdvG4FcvE70XY3czFDbXko2ooExE3NBkjJpyt4yCpRLw/EeUGyK3rdyYDSv6/ NeU8AIf/aIlWd2g== X-Google-Smtp-Source: AGHT+IGNO2Ue2ds5cZZ5nqUeIMkjzsWEzJz65ELSNC02DEQ3gbhoOr1LcC6h7r5RennInGd6igBPLQ== X-Received: by 2002:a05:6a00:1409:b0:73b:9be4:e64a with SMTP id d2e1a72fcca58-73c1fb48cdamr1709757b3a.23.1744760320344; Tue, 15 Apr 2025 16:38:40 -0700 (PDT) Received: from dread.disaster.area (pa49-181-60-96.pa.nsw.optusnet.com.au. [49.181.60.96]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bd22f1259sm9148215b3a.119.2025.04.15.16.38.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 16:38:39 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.98) (envelope-from ) id 1u4prR-000000095N1-0pge; Wed, 16 Apr 2025 09:38:37 +1000 Date: Wed, 16 Apr 2025 09:38:37 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: Christoph Hellwig , zlang@kernel.org, fstests@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH] common: remove USE_EXTERNAL Message-ID: References: <20250414054205.361383-1-hch@lst.de> <20250415004452.GO25675@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250415004452.GO25675@frogsfrogsfrogs> On Mon, Apr 14, 2025 at 05:44:52PM -0700, Darrick J. Wong wrote: > On Mon, Apr 14, 2025 at 07:42:05AM +0200, Christoph Hellwig wrote: > > The USE_EXTERNAL variable indicates that dedicated log or RT devices are > > in use for the scratch and possibly test device. It gets automatically > > set when needed and generally does not provide any benefit over simply > > testing the SCRATCH_LOGDEV and SCRATCH_RTDEV variables. > > > > Remove it and replace that test with test for SCRATCH_LOGDEV and > > SCRATCH_RTDEV, using the more readable if-based syntaxt for all tests > > touched by this change. > > > > Signed-off-by: Christoph Hellwig > > I like this change, but it leaves me wondering why USE_EXTERNAL even > exists in the first place? Is that so that you could add > TEST/SCRATCH_RTDEV to the top of a config file and set > USE_EXTERNAL={yes,no} as a per-section variable? e.g. > > [default] > TEST_RTDEV=/dev/sde > SCRATCH_RTDEV=/dev/sdf > > [rtstuff] > USE_EXTERNAL=yes > > [simple] > USE_EXTERNAL=no Right, that's the way I've been using for a few years, and it is explicitly the way check-parallel expects external device enablement in config sections to work.... -Dave. -- Dave Chinner david@fromorbit.com