Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FAB97828B for ; Tue, 12 Mar 2024 09:58:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710237536; cv=none; b=FDJQD0dZ2F8FzmN03FAm0oJTvQ8urrziYRrQo4nY7oSnBq9TheUunH9IEMhKJqY6JCPF4uPf29FbgE7wvjzJL7FsFpH0fjgcjofBbP4KOILpAojV342WDQNzDHlbUEM8/gZvOwIEtKnvOs3xNTKoYeteK3fmpS0neq1A4bca/gc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710237536; c=relaxed/simple; bh=Y6VdP9faqh72Mn6LhmNnwRXRt34XCvhHGJdaTZngvro=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EUOVDD7eYzwPsdFPe7Fv17nSZl6UWXt7NyBiVz0XiqFX91BWaoBKYsuGh5A+dcyhmmpSktKJMpBl+PwhCNEdkNRAoRRpXNVftFaXoiIqZ9jL9M7BA85nB6rCjppWOnQgOLMno4EOGdc/ahR+KzN0keNlTj4i8AnbpRFUcD1D2zo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=BJYcvynb; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="BJYcvynb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710237534; x=1741773534; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Y6VdP9faqh72Mn6LhmNnwRXRt34XCvhHGJdaTZngvro=; b=BJYcvynbODJvbB4/cfJu0e+W8VcsipoaPkzc6bmOCQamRsA9G26FYdUP ttXtI7IzVlzTkf7xXleDJ+1E1qTwGP/spjhuY6ReiicX8kjiqr6P/yOYo ZsbNqVIPuLOxBVwfojuH+v3nX+6qI4NhTH1X3io8HOSAwtFekbKsoiNBA CAlLHPHX4FbdfuzynOvs3eqseraO1az4lmQMWWTCpCl7ROsB92UjPCx1i 5GwxAoS4t1sKMKYXvHhVgUlaq7Ljo18bercQ3UeGNA45Mxzs4IMGYRVvE bHEhT2DmVbAmWNYJIXr75+YYqaFHE9ALZUqhOKWTta/RWAfT7baLFCPSa w==; X-IronPort-AV: E=McAfee;i="6600,9927,11010"; a="5109251" X-IronPort-AV: E=Sophos;i="6.07,119,1708416000"; d="scan'208";a="5109251" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2024 02:58:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,119,1708416000"; d="scan'208";a="11560026" Received: from liuzhao-optiplex-7080.sh.intel.com (HELO localhost) ([10.239.160.36]) by fmviesa006.fm.intel.com with ESMTP; 12 Mar 2024 02:58:48 -0700 Date: Tue, 12 Mar 2024 18:12:38 +0800 From: Zhao Liu To: "Mi, Dapeng" Cc: Eduardo Habkost , Marcel Apfelbaum , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Yanan Wang , "Michael S . Tsirkin" , Richard Henderson , Paolo Bonzini , Eric Blake , Markus Armbruster , Marcelo Tosatti , Daniel P =?iso-8859-1?Q?=2E_Berrang=E9?= , Xiaoyao Li , qemu-devel@nongnu.org, kvm@vger.kernel.org, Zhenyu Wang , Zhuocheng Ding , Babu Moger , Yongwei Ma , Zhao Liu Subject: Re: [PATCH v9 02/21] hw/core/machine: Support modules in -smp Message-ID: References: <20240227103231.1556302-1-zhao1.liu@linux.intel.com> <20240227103231.1556302-3-zhao1.liu@linux.intel.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > > @@ -51,6 +51,10 @@ static char *cpu_hierarchy_to_string(MachineState *ms) > > g_string_append_printf(s, " * clusters (%u)", ms->smp.clusters); > > } > > + if (mc->smp_props.modules_supported) { > > + g_string_append_printf(s, " * modules (%u)", ms->smp.clusters); > > + } > > smp.clusters -> smp.modules? > Good catch! Thanks! -Zhao