Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C2DD1649C8 for ; Mon, 27 May 2024 21:15:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716844546; cv=none; b=DH+1b/ILjNs/Ex28XtX//cqCkq7IH6VQkIsa4LBUdYdQfaP2t7eIgXpGPso97I/XujJeI6r8cswjv6keUKHyy+RcuRmzgCZ/Xd2wJ0obceyEBMhnOhwhc30PE4hcLC87u+EmdIrSxPkdURWMD1YCJdaLlPIxS+BNs2Cpng52RJo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716844546; c=relaxed/simple; bh=cU4au/xE2uT6iT3b0leCXA1gJWV3T5+VWJ+Zf2Tcpyw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=cyKzOevkOsOfNXjnDXkWVMLJBH1pnQ6c8O3Qa5NFpA5PMxe57Gk9yEj8TOXO1Ptz4v0k4sAixixE+/P9CB/FgWoSA5l4iuhlGy8smMXWmKDEXKcOgkHN26XcUOq4VXY19ofgCVPQKBUqVfNyUkqS03PkrpTSjZiNY7XZESSppgA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--gnoack.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=BpUSUApC; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--gnoack.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BpUSUApC" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-df4d62ff39fso199754276.2 for ; Mon, 27 May 2024 14:15:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1716844544; x=1717449344; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=MV7q+vdtQXuXLfTDMASuNLp3UUHxOfqwGFDJ01F8y3k=; b=BpUSUApCSEXhjaen/jhQM1RQLyXrDZ7s2ySg0wM39edz4jjl0obTwMM8degA0l7Iws mth/JJeVN+rpNdqKhUD3N8qLuPyTVSP+UyvieILVkEZTIq2Y0au7APKIRgWcpucs3Gu+ wZEN25XIeWbQO9k0il4k0QvVkbB/k3RALyN/UjqJIrpO6I9Km0kHDSfgnuCuEAJvcoXk FPHLZyH8knKEyDuHO+bWYC7hxS8607jQzgZuZrSXD7XJCvZm/57fv5fUY05Ew+u0Ah2x 9ZB9GjYAR1QdLbboAzPSJ1SmZ5is3LIlHe35AhDrtqV44octD6++yU0cbH4flz1pu+L8 GbZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716844544; x=1717449344; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=MV7q+vdtQXuXLfTDMASuNLp3UUHxOfqwGFDJ01F8y3k=; b=eDgdQ4/2T7vXD7C2CRgGjcFp9YKyR6w0opCDnX2mgTubpXrvmuNW47vVamtAWa29cH w6/7sXPMZoHglfmHmCF25Z38bQAZ/y1fGYHtxDtEYADjpe4j96yyWM1vaM+F+LXfwoAH vkDWGGxq7SOicNW8gtkIidUdSYRfTS2psgz/W8h0e1NiRSkHbQRDua2lXTQaCrMLxQxh ixui5yY7YDgwtILvmLyHBNhBDeftSsMSNAwI5QXdhrseOD1du2Il5JK6uIFCnrg/dO7J dL1Xlo2eVQuuT563ZxAnMBro5pkrpyBtZkhfQ+C/J+46VX2NjXZCxJuvArumgPscQ5CU ZMkw== X-Forwarded-Encrypted: i=1; AJvYcCUebA8NxRkyxLVNqvJh6BDWMODcfS2EzgOUXlGw+1AQFI4/QBYk45Z5gXi5hS5KLTXMU32W91iyGvzwF21htlUWcz6bGUZ6c1grxXwfZrFIH63CMAL5 X-Gm-Message-State: AOJu0Yz/th2ibzA6YBpM09CbZGoUHsEsHBEKGddCDLSnJZU+V5mE8O5+ rP0IDI2RFKjePP1sk3MIqJBNhZanRi6SjqxBA8xO7s9RIw5m0lhCVFYIqZX4E6WLcS7Dix0V/DA wXw== X-Google-Smtp-Source: AGHT+IHQNShL8pBVopWZLIB8VV4ljsCmllvzBR6phLcoQTAPk/NUOFPVrgumCAbWvKqmFCNb/NtSC9ov8hA= X-Received: from swim.c.googlers.com ([fda3:e722:ac3:cc00:31:98fb:c0a8:1605]) (user=gnoack job=sendgmr) by 2002:a05:6902:114d:b0:df7:a340:4600 with SMTP id 3f1490d57ef6-df7a3404d9dmr1348888276.10.1716844544376; Mon, 27 May 2024 14:15:44 -0700 (PDT) Date: Mon, 27 May 2024 23:15:42 +0200 In-Reply-To: <20240524093015.2402952-7-ivanov.mikhail1@huawei-partners.com> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240524093015.2402952-1-ivanov.mikhail1@huawei-partners.com> <20240524093015.2402952-7-ivanov.mikhail1@huawei-partners.com> Message-ID: Subject: Re: [RFC PATCH v2 06/12] selftests/landlock: Add protocol.rule_with_unhandled_access to socket tests From: "=?utf-8?Q?G=C3=BCnther?= Noack" To: Mikhail Ivanov Cc: mic@digikod.net, willemdebruijn.kernel@gmail.com, gnoack3000@gmail.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, yusongping@huawei.com, artem.kuzin@huawei.com, konstantin.meskhidze@huawei.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Fri, May 24, 2024 at 05:30:09PM +0800, Mikhail Ivanov wrote: > Add test that validates behavior of landlock after rule with > unhandled access is added. >=20 > Signed-off-by: Mikhail Ivanov > --- >=20 > Changes since v1: > * Refactors commit message. > --- > .../testing/selftests/landlock/socket_test.c | 33 +++++++++++++++++++ > 1 file changed, 33 insertions(+) >=20 > diff --git a/tools/testing/selftests/landlock/socket_test.c b/tools/testi= ng/selftests/landlock/socket_test.c > index 57d5927906b8..31af47de1937 100644 > --- a/tools/testing/selftests/landlock/socket_test.c > +++ b/tools/testing/selftests/landlock/socket_test.c > @@ -232,4 +232,37 @@ TEST_F(protocol, rule_with_unknown_access) > EXPECT_EQ(0, close(ruleset_fd)); > } > =20 > +TEST_F(protocol, rule_with_unhandled_access) > +{ > + struct landlock_ruleset_attr ruleset_attr =3D { > + .handled_access_socket =3D LANDLOCK_ACCESS_SOCKET_CREATE, > + }; > + struct landlock_socket_attr protocol =3D { > + .family =3D self->srv0.protocol.family, > + .type =3D self->srv0.protocol.type, > + }; > + int ruleset_fd; > + __u64 access; > + > + ruleset_fd =3D > + landlock_create_ruleset(&ruleset_attr, sizeof(ruleset_attr), 0); > + ASSERT_LE(0, ruleset_fd); > + > + for (access =3D 1; access > 0; access <<=3D 1) { > + int err; > + > + protocol.allowed_access =3D access; > + err =3D landlock_add_rule(ruleset_fd, LANDLOCK_RULE_SOCKET, > + &protocol, 0); > + if (access =3D=3D ruleset_attr.handled_access_socket) { > + EXPECT_EQ(0, err); > + } else { > + EXPECT_EQ(-1, err); > + EXPECT_EQ(EINVAL, errno); > + } > + } > + > + EXPECT_EQ(0, close(ruleset_fd)); > +} > + > TEST_HARNESS_MAIN > --=20 > 2.34.1 > Reviewed-by: G=C3=BCnther Noack Like the commit before, this is copied from net_test.c and I don't want to bikeshed around on code style which was discussed before. Trying to factor out commonalities might also introduce additional layers o= f indirection that would obscure what is happening. I think it should be fin= e like that despite it having some duplication. =E2=80=94G=C3=BCnther