Date: Mon, 27 May 2024 22:51:12 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Kent Gibson <warthog618@gmail.com>,
	Erik Schilling <erik.schilling@linaro.org>,
	Phil Howard <phil@gadgetoid.com>,
	Viresh Kumar <viresh.kumar@linaro.org>, linux-gpio@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [libgpiod][RFC/RFT 06/18] bindings: glib: add examples
Message-ID: <ZlTkMNQ5OGyAgf8A@smile.fi.intel.com>
References: <20240412122804.109323-1-brgl@bgdev.pl>
 <20240412122804.109323-7-brgl@bgdev.pl>
 <Zif8qBoZq7I3Xrbb@smile.fi.intel.com>
 <CAMRc=Mdp1_faK8_1GmyJZanMCDpW_503fRFsigg39+XPoV4acQ@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAMRc=Mdp1_faK8_1GmyJZanMCDpW_503fRFsigg39+XPoV4acQ@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Fri, May 24, 2024 at 08:22:05PM +0200, Bartosz Golaszewski wrote:
> On Tue, Apr 23, 2024 at 8:23 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Fri, Apr 12, 2024 at 02:27:52PM +0200, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

...

> > > +     ret = g_gpiod_line_request_set_value(data->request, data->line_offset,
> > > +                                          data->value, &err);
> > > +     if (!ret) {
> >
> > ret == 0 equals error?!
> 
> It returns gboolean where false means error. This is a pattern in GLib.

For booleans we have a pattern like

	if (bool_func(...))

to imply it.

	ret = int_func(...);
	if (ret) // if (!ret)

kinda implies int. Does Glib has that type of pattern?

> > > +             g_printerr("failed to set line value: %s\n", err->message);
> > > +             exit(EXIT_FAILURE);
> >
> > Don't you have something like err->code to propagate?
> 
> What for? err->message is the human-readable string of the error.

If somebody wants to parse this with a script?

-- 
With Best Regards,
Andy Shevchenko