Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4F48144D19 for ; Mon, 10 Jun 2024 16:44:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718037846; cv=none; b=mIkgsXU4xnv0N9GzmR7ycFI94kknPk7cXaA3Sc8NJW2uclqaA/Ae8X3FkM1H+zj7FL8/QmCOx4PmU7c/w3Ad7MgqRJ+CWzNueJMMv3kk6f1KMGn8nNGUxsb3uZyNfDHZa0TlUEtLQF3uW6orchqlCitwlWZZTuQmuS7IkBSapOQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718037846; c=relaxed/simple; bh=xlRyyKorKOkhZQWkf8a+nVC2AGE5Tsed48f95tQ+Bjs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T1gjszaoPuEKqt8MyO6hMeDApJt+7KQ8BZ2x4x8ZsecLmtNxRB66oN1lqiJjTRlhvQ/qOvsz3PHR53w+UB1yhgl5S+vCQEL0sN+rUje9rWpbP/gST06HQ2XoaLLGU2f9BwmP5tCbld4nOqL7egmiIjWIjgwPgQb5guTgYJGmSvY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=vVV7wJzR; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vVV7wJzR" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-681ad081695so62304a12.3 for ; Mon, 10 Jun 2024 09:44:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1718037844; x=1718642644; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZWJrFt56Ba2XKaEKUnUCqUmu/jVW4Te91KO0JGqkT1U=; b=vVV7wJzRXeB3sZmGcJE71gHQuld85DUnCFugMhjYU3T4QniZ0LJvImsxKJxukpEWMd mTuRH8N/OOfUrus04eWls6VFT3/o+gPSxRffI4eRDy9T7Xqof+QPO1a6QJOMV1JnmwDe s7TeUx5LeDCoFcfm5rRMi5DFcuWl1DenPA/DZqGE3pU20Oy1JESvJ9h1sTEJIWKWNCzD SgbgztELPXPo27jutHk8cxDYpB7QYrthombm4u/RPTsFyv+JcS/R4X21B09nBwnymk3G cVp5is2P8G/gnoSEobw+YZVR4OBCPiGEh0Fq7mtaKOlgSbBrVGBHXIFTcI+GRpHuffEM CALg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718037844; x=1718642644; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZWJrFt56Ba2XKaEKUnUCqUmu/jVW4Te91KO0JGqkT1U=; b=Yw4BOHYooRkgWM7ini/AIugt50kl5b3Xmt14nZyLEnTV7I8vcgcfwj6otopeLJa4r1 9pXm1BZH7Ey9wFXrmVRF+eg5OFsiubd0qxow04YSTexlkJ9ukmTMBTb59Q/SUs903MmM LXCVHjG2k+ThmnSKloXGPeXa1aWE1sm7Rc2vYv9klx+xySx8222Ml2lDrqEJbYE5AYJU kRFrByJ0HxOBM1LqoOosygir3ua7W0CiKVJuse81ChIM7GYkP8f8iqtPgfyc99q5xtqH OQdQ3i2agZ1e/BgG8sEYQE5aBXv8lUEINsAn+niNrhMA0HxHEQYCvv+FeeONjoPYZ28g /qEQ== X-Forwarded-Encrypted: i=1; AJvYcCUpQjZCfdKltxqNdeltWfVXlFKKFw6AcoOcaD6EjcSUXwWtISh9kWJpnzIyEtU8L66BQfiEGTiqYU696258TD+hN9wWNchLM2R/kcA= X-Gm-Message-State: AOJu0YwnZzCj87u4ywTWoOBNRDVZ47YsV78PGUZUCBaL9p4YisEkNB7I o537C/axtCa9LDzv0LG+GDUq+OW0sTG+YLom/i0FuyDXxbI2IzpW+PLjfkLwcw== X-Google-Smtp-Source: AGHT+IFO/T7QbJyG6RfIGM4sbC0wUi2kSF81e1T/t2MsMvtblCbstqePphSLuWts4/pUFHivpG5mhw== X-Received: by 2002:a17:90b:1c8c:b0:2c2:3de7:20c0 with SMTP id 98e67ed59e1d1-2c2bcc4cd43mr8521758a91.37.1718037843726; Mon, 10 Jun 2024 09:44:03 -0700 (PDT) Received: from google.com (226.75.127.34.bc.googleusercontent.com. [34.127.75.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c28066d57esm11358284a91.19.2024.06.10.09.44.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 09:44:03 -0700 (PDT) Date: Mon, 10 Jun 2024 16:43:59 +0000 From: Carlos Llamas To: Barry Song <21cnbao@gmail.com> Cc: linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org, sumit.semwal@linaro.org, Brian.Starkey@arm.com, benjamin.gaignard@collabora.com, christian.koenig@amd.com, dri-devel@lists.freedesktop.org, jstultz@google.com, linux-kernel@vger.kernel.org, tjmercier@google.com, v-songbaohua@oppo.com, hailong.liu@oppo.com Subject: Re: [PATCH] dma-buf/heaps: Correct the types of fd_flags and heap_flags Message-ID: References: <20240606020213.49854-1-21cnbao@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240606020213.49854-1-21cnbao@gmail.com> On Thu, Jun 06, 2024 at 02:02:13PM +1200, Barry Song wrote: > From: Barry Song > > dma_heap_allocation_data defines the UAPI as follows: > > struct dma_heap_allocation_data { > __u64 len; > __u32 fd; > __u32 fd_flags; > __u64 heap_flags; > }; > > But dma heaps are casting both fd_flags and heap_flags into > unsigned long. This patch makes dma heaps - cma heap and > system heap have consistent types with UAPI. > > Signed-off-by: Barry Song > --- Looks good to me, thanks! Reviewed-by: Carlos Llamas