Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1FCAC27C53 for ; Wed, 19 Jun 2024 18:01:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJzcB-0007fS-R3; Wed, 19 Jun 2024 14:00:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJzc4-0007ey-Bg for qemu-riscv@nongnu.org; Wed, 19 Jun 2024 14:00:53 -0400 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJzc1-00019x-Nl for qemu-riscv@nongnu.org; Wed, 19 Jun 2024 14:00:51 -0400 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-7061365d2f3so78709b3a.3 for ; Wed, 19 Jun 2024 11:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1718820048; x=1719424848; darn=nongnu.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=suWG7OInWA/FXp2HXBeEnprq+0zC+QBXlPUz212nYjY=; b=mBBLY7i7gzkODA20+zHZPxK9OhKn6LBWSen4Pv0rLlgTvlf11vG2lcVVJvYQzZDfLS T9QeZqKbeCbdg3NpPBve4PYEBxfFIw3M4azdXQTSEilx/ek4Rpt/4Zvw+S/30USDE6vm x+aVEr52DAu6PKHq3K3J6DISLGZxVuyAX+rC4BHpIOT3N1ZXdJXbKBAJXIYVMGV12Rcu R6A/vT1qTkYZ2pYzZch9tLzAyIskxEE2Gpl3WwYxjif+oYxIEiAWpBMO7zzdQgGxNIMJ uZmdYouJ9WMDlFvglQLxVNj275hfU8JfZI5h730JK5yVH18QfMm6iqHVz/ZIQr3/O9kZ hTOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718820048; x=1719424848; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=suWG7OInWA/FXp2HXBeEnprq+0zC+QBXlPUz212nYjY=; b=jNCYIA+4AwgW2Bgk+DTxk0K+oTctf6GKGRg9h6EjqMsKwW1IXRdoT+oXaDHSygN7yF lMd+9ZITgAyc8oP6CnIjdDSu+sKXvwoOrmRDRVw59EBFMuq6lVmmKadk+mIunOn312+L WcNCy8Fb5zqf4ALXnVn5bgvXTTf7anjiW5WBkAy4Gp7O4xFH81mt50vmSPWuZTF9hw19 ZsmKJUCk0V8dZPMKAw7Er6iz3iwp37yHczUJqSL9cKH6/cjiGpKlkHnJEYEMAgg4Ebs7 Qzf+/MutP6IZSAhcp8Id5AYYHX9rbKbFZOH1VXgC8b+oIVHMqZt2+UAwsjjimuc9TC67 1jeQ== X-Forwarded-Encrypted: i=1; AJvYcCWDoxHK28H4hURYg3P8UWDfK0fvCb4l4HeuKuxW+1+g4Sx4lOTQ1y6d8lmIpB8UpZt+vbtwyd+qJHzyxkOu5ppEizsUuR4= X-Gm-Message-State: AOJu0YydjPPTxT6CwIkRLOQts+zOvmgjxWcf4ZIVL5g8O/IIODvPW4Ej vSkb8n8c0nJ5MmGYgCotIU3seZ/W9Pntdw48ddicEWM/jpJzAR/WkwLqFhzlmk4= X-Google-Smtp-Source: AGHT+IHaFZ+UalIX4rTQwAS6VjeGqTC/jG9rqA9pISeIp9cCsbziGGKzpkY/aQa7qfLNEeTCus+bTg== X-Received: by 2002:a05:6a20:3d8b:b0:1b6:a7c5:4fbe with SMTP id adf61e73a8af0-1bcbb3eed25mr4064219637.14.1718820047594; Wed, 19 Jun 2024 11:00:47 -0700 (PDT) Received: from sunil-laptop ([106.51.187.237]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705cc91f6a4sm11380845b3a.13.2024.06.19.11.00.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jun 2024 11:00:47 -0700 (PDT) Date: Wed, 19 Jun 2024 23:30:35 +0530 From: Sunil V L To: "Michael S. Tsirkin" Cc: Igor Mammedov , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Daniel P =?utf-8?B?LiBCZXJyYW5nw6k=?= , Thomas Huth , Ani Sinha , Laurent Vivier , Gerd Hoffmann , Alistair Francis , Sia Jee Heng , Haibo1 Xu , Anup Patel , Andrew Jones , Daniel Henrique Barboza , Peter Maydell , Palmer Dabbelt , Bin Meng , Weiwei Li , Liu Zhiwei , Alistair Francis Subject: Re: [PATCH v2 06/12] tests/data/acpi/virt: Move ACPI tables under aarch64 Message-ID: References: <20240524061411.341599-1-sunilvl@ventanamicro.com> <20240524061411.341599-7-sunilvl@ventanamicro.com> <27cef750-262a-402a-97fe-c4a55700a376@linaro.org> <20240619111743.58930119@imammedo.users.ipa.redhat.com> <20240619052043-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240619052043-mutt-send-email-mst@kernel.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::435; envelope-from=sunilvl@ventanamicro.com; helo=mail-pf1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On Wed, Jun 19, 2024 at 05:20:50AM -0400, Michael S. Tsirkin wrote: > On Wed, Jun 19, 2024 at 11:17:43AM +0200, Igor Mammedov wrote: > > On Mon, 27 May 2024 20:46:29 +0530 > > Sunil V L wrote: > > > > > On Mon, May 27, 2024 at 12:12:10PM +0200, Philippe Mathieu-Daudé wrote: > > > > Hi Sunil, > > > > > > > > On 24/5/24 08:14, Sunil V L wrote: > > > > > Since virt is a common machine name across architectures like ARM64 and > > > > > RISC-V, move existing ARM64 ACPI tables under aarch64 folder so that > > > > > RISC-V tables can be added under riscv64 folder in future. > > > > > > > > > > Signed-off-by: Sunil V L > > > > > Reviewed-by: Alistair Francis > > > > > --- > > > > > tests/data/acpi/virt/{ => aarch64}/APIC | Bin > > > > > > > > The usual pattern is {target}/{machine}, so instead of: > > > > > > > > microvm/ > > > > pc/ > > > > q35/ > > > > virt/aarch64/ > > > > virt/riscv64/ > > > > > > > > (which is odd because q35 is the x86 'virt'), I'd rather see: > > > > > > > > x86/microvm/ > > > > x86/pc/ > > > > x86/q35/ > > > > aarch64/virt/ > > > > riscv64/virt/ > > > > > > > > Anyhow just my 2 cents, up to the ACPI maintainers :) > > > > > > > Hi Phil, > > > > > > Your suggestion does make sense to me. Let me wait for feedback from > > > ARM/ACPI maintainers. > > > > I'd prefer {target}/{machine} hierarchy like Philippe suggests > > Agreed. > Thanks for the confirmation!. Let me send the updated version soon. Moving pc/q35/microvm also under new x86 would need many changes in bios-table-test.c. So, the question is, are you ok to combine x86 changes as well in this series or prefer to it later in separate series? Thanks, Sunil