Date: Tue, 9 Jul 2024 14:31:22 +0200 From: Frank Lichtenheld Message-ID: References: <20240708210912.566-1-chipitsine@...277...> <20240708210912.566-6-chipitsine@...277...> MIME-Version: 1.0 In-Reply-To: <20240708210912.566-6-chipitsine@...277...> Subject: Re: [Openvpn-devel] [PATCH 5/5] tests/unit_tests/openvpn/test_auth_token.c: handle strdup errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit Content-Disposition: inline To: Ilia Shipitsin Cc: openvpn-devel@lists.sourceforge.net On Mon, Jul 08, 2024 at 11:08:22PM +0200, Ilia Shipitsin wrote: > Signed-off-by: Ilia Shipitsin > --- > tests/unit_tests/openvpn/test_auth_token.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/unit_tests/openvpn/test_auth_token.c b/tests/unit_tests/openvpn/test_auth_token.c > index 3a3cb69b..8a0c16af 100644 > --- a/tests/unit_tests/openvpn/test_auth_token.c > +++ b/tests/unit_tests/openvpn/test_auth_token.c > @@ -245,6 +245,7 @@ auth_token_test_known_keys(void **state) > now = 0; > /* Preload the session id so the same session id is used here */ > ctx->multi.auth_token_initial = strdup(now0key0); > + assert_non_null(ctx->multi.auth_token_initial); > > /* Zero the hmac part to ensure we have a newly generated token */ > zerohmac(ctx->multi.auth_token_initial); > @@ -374,6 +375,7 @@ auth_token_test_random_keys(void **state) > now = 0x5c331e9c; > /* Preload the session id so the same session id is used here */ > ctx->multi.auth_token_initial = strdup(random_token); > + assert_non_null(ctx->multi.auth_token_initial); > > free_key_ctx(&ctx->multi.opt.auth_token_key); > auth_token_init_secret(&ctx->multi.opt.auth_token_key, random_key, true); Acked-by: Frank Lichtenheld Regards, -- Frank Lichtenheld